On 30/05/14 19:08, Michele Baldessari wrote:
On Fri, May 09, 2014 at 11:31:05PM +0100, Michele Baldessari wrote:
> Hi,
>
> here is a patchset that implements ethtool statistics, which I am using
> to extend PCP (
http://oss.sgi.com/projects/pcp/) to collect ethtool
> statistics.
>
> I also include some assorted fixes to make coverity happy.
>
> Let me know if you have any questions or feedback.
>
> Kind regards,
> Michele
>
> Michele Baldessari (5):
> Update ethtool-copy.h
> Implement ethtool statistics
> Close a leaking descriptor in get_devices()
> Remove spurious err variable
> Make sure __struct_desc_create_dict returns NULL in case of error
>
> python-ethtool/ethtool-copy.h | 47 +++++++++++++++
> python-ethtool/ethtool.c | 131 +++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 176 insertions(+), 2 deletions(-)
Ping?
Hi,
Sorry for the long delay. It's just been busy to do a full review of
these patches.
Generally speaking, patches 3-5 looks fine at first glance. In regards
to the statistics patches, I like such a feature! However, I'm trying
to move away from the old API ( ethtool.{get,set}_*($DEVICE) ) and
rather put it into the object oriented API. So moving in that direction
is highly appreciated.
There are plans on my TODO list to move the old API completely over to
the new one as well. But time ..... In addition, I've been holding off
a little bit to see what would happen with libnl3's Python support - and
it seems the libnl3 team is not putting much efforts into that area now,
so python-ethtool will be needed too.
Just one question. I see that your stats patches uses ioctl() to
extract this information. Do you know if these stats are comparable to
the information which can be extracted from libnl3?
<
http://www.carisma.slowglass.com/~tgr/libnl/doc/route.html#tc_stats>
--
kind regards,
David Sommerseth