Re: [PATCH] remove redundant material from setup.py

[David Malcolm]

On Tue, 2013-01-15 at 14:31 -0500, David Malcolm wrote:
>  davids gave me push rights to
>    http://git.fedorahosted.org/cgit/python-ethtool.git
>  so I've gone ahead and committed/pushed this change there as:
>
> http://git.fedorahosted.org/cgit/python-ethtool.git/commit/?id=7c4d887595...
>  
>  Note that I don't think I have rights to:
>   http://fedorapeople.org/cgit/dsommers/public_git/python-ethtool.git/
>  so that doesn't show the change.
>  
>  I believe that the plan is that
>  http://git.fedorahosted.org/cgit/python-ethtool.git
>  should be the canonical "upstream" git repo. 
davids for some reason hasn't been receiving these emails, but he gave
me permission to commit/push my changes, so I've gone ahead and pushed
this to http://git.fedorahosted.org/cgit/python-ethtool.git as
7c4d887595622d23d6f84b774494c140a8a782c0.


>  On Thu, 2012-12-13 at 05:25 -0500, David Malcolm wrote:
>  > On Thu, 2012-12-13 at 05:14 -0500, David Malcolm wrote:
>  > > Commit d3fd6b84f461a4d7ffbf3f3eae37381150b69e82 introduced an ext_modules
>  > > keyword argument to the setup invocation in setup.py, making the
>  > > 
>  > >    ext_modules=Extension(...)
>  > Gah,
>  >     ethtool = Extension(...)
>  > I meant to say.
>  > > 
>  > > code at the top of setup.py redundant.  Remove the redundant code.
>  > 
>  > > ---
>  > >  setup.py | 4 ----
>  > >  1 file changed, 4 deletions(-)
>  > > 
>  > > diff --git a/setup.py b/setup.py
>  > > index b8cbe9f..f081aa6 100644
>  > > --- a/setup.py
>  > > +++ b/setup.py
>  > > @@ -6,10 +6,6 @@ import sys
>  > >  
>  > >  version = '0.7'
>  > >  
>  > > -ethtool = Extension('ethtool',
>  > > -		    sources = ['python-ethtool/ethtool.c',
>  > > -                               'python-ethtool/etherinfo.c',
> 'python-ethtool/etherinfo_obj.c'])
>  > > -
>  > >  def pkgconfig(pkg):
>  > >      def _str2list(pkgstr, onlystr):
>  > >          res = []