[PATCH] Fixed segment fault bug when use logging API at i386 platform

[Yunkai Zhang]

This bug cause by qb_vsprintf_serialize function. It parse "%llx" format
as _long_ other than _long long_.

At x86_64 platform, both sizeof(long) and sizeof(long long) is 8, this
issue would not be triggered, so we could only catch it at i386.

Signed-off-by: Yunkai Zhang <qiushu.zyk(a)taobao.com&gt;
---
 lib/log_format.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lib/log_format.c b/lib/log_format.c
index b4032d9..534edc8 100644
--- a/lib/log_format.c
+++ b/lib/log_format.c
@@ -314,6 +314,7 @@ reprocess:
 			if (*format == 'l') {
 				type_long = 0;
 				type_longlong = 1;
+				format++;
 			}
 			goto reprocess;
 		case 'd': /* int argument */
-- 
1.7.6.4

[Angus Salkeld]

On Thu, Oct 13, 2011 at 05:59:55PM +0800, Yunkai Zhang wrote:
>  This bug cause by qb_vsprintf_serialize function. It parse
> "%llx" format
>  as _long_ other than _long long_.
>  
>  At x86_64 platform, both sizeof(long) and sizeof(long long) is 8, this
>  issue would not be triggered, so we could only catch it at i386. 
Thanks, applied.

Sorry for the long delay, I have been on holiday.

Regards
Angus

>  
>  Signed-off-by: Yunkai Zhang <qiushu.zyk(a)taobao.com&gt;
>  ---
>   lib/log_format.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>  
>  diff --git a/lib/log_format.c b/lib/log_format.c
>  index b4032d9..534edc8 100644
>  --- a/lib/log_format.c
>  +++ b/lib/log_format.c
>  @@ -314,6 +314,7 @@ reprocess:
>   			if (*format == 'l') {
>   				type_long = 0;
>   				type_longlong = 1;
>  +				format++;
>   			}
>   			goto reprocess;
>   		case 'd': /* int argument */
>  -- 
>  1.7.6.4

[Yunkai Zhang]

thanks:)

On Tue, Oct 18, 2011 at 6:35 AM, Angus Salkeld <asalkeld(a)redhat.com&gt; wrote:
>  On Thu, Oct 13, 2011 at 05:59:55PM +0800, Yunkai Zhang wrote:
> > This bug cause by qb_vsprintf_serialize function. It parse "%llx" format
> > as _long_ other than _long long_.
> >
> > At x86_64 platform, both sizeof(long) and sizeof(long long) is 8, this
> > issue would not be triggered, so we could only catch it at i386.
>
>  Thanks, applied.
>
>  Sorry for the long delay, I have been on holiday.
>
>  Regards
>  Angus
>
> >
> > Signed-off-by: Yunkai Zhang <qiushu.zyk(a)taobao.com&gt;
> > ---
> >  lib/log_format.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/lib/log_format.c b/lib/log_format.c
> > index b4032d9..534edc8 100644
> > --- a/lib/log_format.c
> > +++ b/lib/log_format.c
> > @@ -314,6 +314,7 @@ reprocess:
> >                       if (*format == 'l') {
> >                               type_long = 0;
> >                               type_longlong = 1;
> > +                             format++;
> >                       }
> >                       goto reprocess;
> >               case 'd': /* int argument */
> > --
> > 1.7.6.4
>  _______________________________________________
>  quarterback-devel mailing list
>  quarterback-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/quarterback-devel
>  


-- 
Yunkai Zhang
Work at Taobao