On Fri, Mar 03, 2017 at 02:18:03PM -0800, Adam Williamson wrote:
On Fri, 2017-03-03 at 18:12 +0100, Pierre-Yves Chibon wrote:
> To avoid this, one way would be to add to the taskotron message sent the task id
> of the build taskotron was testing.
>
> Would this be something that is doable?
So I think it should be *possible*, but taking a look at the current
Taskotron setup, I think it'd need a change in the Koji triggers. The
Koji triggers don't currently include the Koji task ID in the trigger
data, so when the task runs, it doesn't have that information available
to include in the report that gets submitted to ResultsDB.
This is the kind of thing we could put into resultsdb_conventions quite
nicely, in fact - a convention for 'result of a test associated with a
Koji task', which would store info like the Koji task ID. Just like the
convention for results associated with a compose that has productmd
metadata stores relevant bits of the productmd metadata into the
extradata like this:
productmd.image.type dvd
productmd.image.subvariant Server
productmd.compose.name Fedora
etc., we could do:
koji.id 123
koji.method build
koji.build foo-1.2-3
kinda thing. (or maybe koji.task.id if we want to have differing
conventions for koji tasks, builds etc.)
I don't think this would be much work to change in Taskotron, but I may
be missing something :)
If I read things correctly taskotron already reports the bodhi update it tested,
so adjusting for koji should be feasible, but not knowing the source code I
can't quite estimate how easy/hard it would be :)
Pierre