On Mon, Mar 06, 2017 at 10:17:06AM -0800, Adam Williamson wrote:
On Mon, 2017-03-06 at 12:00 -0500, Kamil Paral wrote:
> > If we implement a 'scenario' key, we can then just teach Bodhi to look
> > for that and combine it with the item, then maybe if it can't find one,
> > treat 'testname-arch' as the scenario (as a fallback for old results,
>
> We don't have that many tests yet, and all of them are basically
> under our control, so if we end up doing this, I think we should
> simply push a patch to all of them (should be fairly easy) and avoid
> any legacy handling.
Well, the case I was thinking of is specifically Bodhi: even if we
adjust things so that all results *going forward* have a scenario key,
*existing* results will not, and often updates sit around in Bodhi for
a long time before going stable. If we make Bodhi only work if the
result has a 'scenario' key, it'll either break or not be able to
display test results for older updates, I think. (And I think Bodhi
shows results even for stable updates, so really, don't we need it to
be able to handle the existing results for all non-EOL releases?)
I'd vote "no" on this on worrying about Bodhi supporting both the new
and the old way. That's just visualization in Bodhi. If the results
disappeared from the UI for some updates for a short period of time
while we cut over to new scenario based keys, then no big loss. If we
really need the results for some audit reason, we can also go dig them
up directly in resultsdb. That would be an exceptional situation.