[rhq] Branch 'bug/731034' - modules/enterprise

[Robert Buck]

modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/CoreGUI.java
           |   33 +++++++++-

modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/UserSessionManager.java
|    4 -
 2 files changed, 33 insertions(+), 4 deletions(-)

New commits:
commit 9aacd63f5de388272344554f6e337ec8c2593b2a
Author: Robert Buck <rbuck(a)redhat.com&gt;
Date:   Tue Aug 30 10:02:50 2011 -0400

    added event listener infrastructure to separate concerns; rpc-tracker becomes
activity-indicator; discovered recursive history call behavior which created new request
ids, still a problem; added native event preview handler to _get above_ the history
calls.

diff --git
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/CoreGUI.java
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/CoreGUI.java
index ecf9101..d1b93d6 100644
---
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/CoreGUI.java
+++
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/CoreGUI.java
@@ -24,10 +24,15 @@ import com.google.gwt.core.client.GWT;
 import com.google.gwt.dom.client.Element;
 import com.google.gwt.dom.client.EventTarget;
 import com.google.gwt.dom.client.NativeEvent;
+import com.google.gwt.event.dom.client.KeyCodes;
 import com.google.gwt.event.logical.shared.ValueChangeEvent;
 import com.google.gwt.event.logical.shared.ValueChangeHandler;
 import com.google.gwt.http.client.URL;
-import com.google.gwt.user.client.*;
+import com.google.gwt.user.client.DOM;
+import com.google.gwt.user.client.Event;
+import com.google.gwt.user.client.History;
+import com.google.gwt.user.client.Timer;
+import com.google.gwt.user.client.Window;
 import com.google.gwt.user.client.Window.Location;
 import com.smartgwt.client.core.KeyIdentifier;
 import com.smartgwt.client.types.Overflow;
@@ -280,6 +285,23 @@ public class CoreGUI implements EntryPoint,
ValueChangeHandler<String>, Event.Na
             rootCanvas.draw();
 
             History.addValueChangeHandler(this);
+
+            Event.addNativePreviewHandler(new Event.NativePreviewHandler() {
+                @Override
+                public void onPreviewNativeEvent(Event.NativePreviewEvent event) {
+                    Event what = Event.as(event.getNativeEvent());
+                    switch (what.getTypeInt()) {
+                        case Event.ONKEYDOWN:
+                            if (what.getKeyCode() != KeyCodes.KEY_ENTER) {
+                                break;
+                            }
+                        case Event.ONCLICK:
+                        case Event.ONDBLCLICK:
+                            makeRequestId();
+                            break;
+                    }
+                }
+            });
         }
 
         if (History.getToken().equals("") ||
History.getToken().equals(LOGOUT_VIEW)) {
@@ -310,13 +332,18 @@ public class CoreGUI implements EntryPoint,
ValueChangeHandler<String>, Event.Na
     }
 
     public void onValueChange(ValueChangeEvent<String> stringValueChangeEvent) {
-        currentView = URL.decodeComponent(stringValueChangeEvent.getValue());
+        final String oldView = currentView;
+        final String newView  = URL.decodeComponent(stringValueChangeEvent.getValue());
+        currentView = newView;
+
         Log.debug("Handling history event for view: " + currentView);
 
         currentViewPath = new ViewPath(currentView);
         coreGUI.rootCanvas.renderView(currentViewPath);
 
-        makeRequestId();
+        if (!newView.equals(oldView)) {
+            makeRequestId();
+        }
     }
 
     public static void refresh() {
diff --git
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/UserSessionManager.java
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/UserSessionManager.java
index 592a23c..56c3658 100644
---
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/UserSessionManager.java
+++
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/UserSessionManager.java
@@ -28,7 +28,9 @@ import com.google.gwt.http.client.RequestBuilder;
 import com.google.gwt.http.client.RequestCallback;
 import com.google.gwt.http.client.RequestException;
 import com.google.gwt.http.client.Response;
-import com.google.gwt.user.client.*;
+import com.google.gwt.user.client.Cookies;
+import com.google.gwt.user.client.History;
+import com.google.gwt.user.client.Timer;
 import com.google.gwt.user.client.rpc.AsyncCallback;
 
 import org.rhq.core.domain.auth.Subject;