On Thu, Oct 12, 2023 at 11:22 PM David Michael
<fedora.dm0(a)gmail.com> wrote:
>
> Hi,
Hi!
> The firecracker-1.5 update has a few new crate dependencies. These
> are compatible minor version updates:
>
> clap-4.4.6 (from 4.4.4)
> regex-1.9.6 (from 1.9.5)
I'm already working on both of these, so this should be resolved soon.
I can't promise to get them done by tomorrow, but I think I'll be able
to get to them this weekend. :)
> A new crate is added:
>
> clap-num-1.0.2
https://bugzilla.redhat.com/2243746
I'll try to review this one tomorrow.
> And there are three updates with incompatible API versions:
>
> kvm-ioctls-0.15.0
> nix-0.27.1
> userfaultfd-0.7.0
>
> I will include userfaultfd as part of the Firecracker update since
> it's the only user of that crate.
Sounds good to me!
> The nix crate has many users, and it seems to get compatibility
> packages for API updates. Can that be done for 0.26, or should I try
> to downgrade the crate with a patch?
Yes, nix is always a bit tricky to handle. I hadn't pushed the v0.27
update yet since dependent projects were slow up the uptake with this
version for some reason, and almost nothing depends on v0.27 yet as
far as I can tell. If firecracker has started depending on v0.27, I'll
push the v0.27 update and a compat package for v0.26 soon.
> It seems like krun and sev are the only other users of kvm-ioctls, and
> they have open-ended version dependencies (>=0.12.0). Is it
> straightforward to update kvm-ioctls then? I would rather not try to
> downgrade this via patching since features in the release changelog
> depend on the new version.
Open-ended dependencies like these are almost always a mistake.
I don't assume they're *really* claiming to be compatible with all
future - and potentially API-breaking - releases ;)
I think last time Sergio wanted to avoid compat packages for these crates?
But if firecracker depends on the new version and sevctl and krun
depend on the current version, I don't really see a way around a
compat package.
Thanks for the heads up. I've just confirmed libkrun builds and works just fine
with kvm-ioctl-0.15.0, so no problems here.
Sergio.