Re: [PATCH 4/4] README.dev: update userstorage doc

[Nir Soffer]

On Thu, Oct 6, 2022 at 5:12 PM Albert Esteve <aesteve(a)redhat.com&gt; wrote:

>  Update documentation regarding userstorage
>  setup and teardown.
>
>  Signed-off-by: Albert Esteve <aesteve(a)redhat.com&gt;
>  ---
>   README.dev | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
>
>  diff --git a/README.dev b/README.dev
>  index aafbf34..6d9ed14 100644
>  --- a/README.dev
>  +++ b/README.dev
>  @@ -54,9 +54,13 @@ Or using environment variable:
>   Testing 4K support
>   ==================
>
>  -To enable the 4k tests, you need to setup 4k stroage for the tests:
>  +To enable the 4k tests, you need to have userstorage installed:
>
>  -    $ python tests/storage.py setup
>  +    $ python -m pip install userstorage
>  
Installing user storage like this is not a good idea - this will try to
install it
as root.

We show here how to create a virtual environment and install the packages
required for sanlock testing (tox, userstorage), and how to activate and
deactivate
the environment.


>  +
>  +Then, you just need to setup 4k storage for the tests:
>  +
>  +    $ userstorage create tests/storage.py
>
>   This creates two loop devices with 4k sector size; one for testing
>  sanlock with
>   4k block device, and the other for testing with a filesystem backed by a
>  4k
>  @@ -64,7 +68,7 @@ block device.
>
>   To teardown the storage:
>
>  -    $ python tests/storage.py teardown
>  +    $ userstorage delete tests/storage.py
>
>   The script unmounts the filesystem and detaches the loop devices.
>
>  --
>  2.37.3
>
>