Re: init.d/sanlk-resetd.service

[Nir Soffer]

----- Original Message -----
>  From: "David Teigland" <teigland(a)fedoraproject.org&gt;
>  To: sanlock-devel(a)lists.fedorahosted.org
>  Sent: Wednesday, August 6, 2014 7:50:02 PM
>  Subject: init.d/sanlk-resetd.service
>  
>  init.d/sanlk-resetd.service |   11 +++++++++++
>   1 file changed, 11 insertions(+)
>  
>  New commits:
>  commit 415f7ec9473fc9254f6f88314ef6ff2ce7e0f49d
>  Author: David Teigland <teigland(a)redhat.com&gt;
>  Date:   Wed Aug 6 11:49:15 2014 -0500
>  
>      init: add service file for sanlk-resetd
>      
>      Signed-off-by: David Teigland <teigland(a)redhat.com&gt;
>  
>  diff --git a/init.d/sanlk-resetd.service b/init.d/sanlk-resetd.service
>  new file mode 100644
>  index 0000000..44a88a6
>  --- /dev/null
>  +++ b/init.d/sanlk-resetd.service
>  @@ -0,0 +1,11 @@
>  +[Unit]
>  +Description=daemon for host reset
>  +After=syslog.target wdmd.service sanlock.service 
I think you need Requires= or Wants= - After will only take effect if services are
started together. If no services are required or wanted, I guess that systemd will
happily ignore the After directive.

Even if this works, it is better to be explicit.

See http://www.freedesktop.org/software/systemd/man/systemd.unit.html#Before=

>  +
>  +[Service]
>  +Type=forking
>  +ExecStart=/usr/sbin/sanlk-resetd 
Don't you need a PIDFile= option here? How systemd can control the daemon otherwise?

See http://www.freedesktop.org/software/systemd/man/systemd.service.html#Type=

>  +
>  +[Install]
>  +WantedBy=multi-user.target
>  +
>  
>  
>  _______________________________________________
>  sanlock-devel mailing list
>  sanlock-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/sanlock-devel
>