Re: [PATCH] python: improve rem_lockspace API doc wording

[Nir Soffer]

On Tue, Apr 16, 2019 at 10:37 PM Vojtech Juranek <vjuranek(a)redhat.com&gt;
wrote:

>  ---
>   python/sanlock.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
>  diff --git a/python/sanlock.c b/python/sanlock.c
>  index b387307..3bfd1f2 100644
>  --- a/python/sanlock.c
>  +++ b/python/sanlock.c
>  @@ -746,8 +746,9 @@ rem_lockspace(lockspace, host_id, path, offset=0,
>  async=False, unused=False)\n\
>   Remove a lockspace, releasing the acquired host_id. If async is True
>  the\n\
>   function will return immediately and the status can be checked using\n\
>   inq_lockspace. If unused is True the command will fail (EBUSY) if there
>  is\n\
>  -at least one acquired resource in the lockspace (instead of
>  automatically\n\
>  -release it).");
>  +at least one acquired resource in the lockspace. Otherwise (the
>  default)\n\
>  +sanlock will try to terminate processes holding resource leases and
>  upon\n\
>  +successful termination these leases will be released.");
>  
Looks good.

Adding a note about the time this may block can be helpful, but this is
probably
true for other functions and  we can improve it later.

Nir



>   static PyObject *
>   py_rem_lockspace(PyObject *self __unused, PyObject *args, PyObject
>  *keywds)
>  --
>  2.20.1
>
>
>