Hello,
This mail contains all the patches that I have so far in my git.
--------------------------
The following set of patches is related to comments and unchanged from the previous submission. I replied to the comments about them in another mail. I do not think there is anything to address. If there is please let me know.
0001-INI-Do-not-check-validity-of-comments.patch 0002-INI-Extend-error-set-and-add-parsing-error.patch 0003-INI-Process-c-style-comments.patch 0004-INI-Test-files-for-unit-test.patch 0005-INI-Unit-test-for-c-style-comments.patch
--------------------------
The following set of patches addresses comments and fixes bugs in Unicode/UTF8 conversion
0006-INI-Expose-buffer-context-as-void.patch 0007-INI-Extend-internal-file-handle.patch 0008-INI-Convert-files-to-UTF.patch 0009-INI-Updated-unit-test-for-UTF8-conversion.patch
Thanks for review Lukas. I reworked the code significantly. I think I addressed everything except the initialization comment. I agree with you that it would have been better to initialize things outside the loop but I need to read the first buffer to be able to determine the encoding. This is what causes this logic. I do not see a way to avoid it so left that part as is.
----------------------------
The following one liner fixes a trace text 0010-INI-Fix-typo-in-comment.patch
----------------------------
The following patches are related to the problem I noticed earlier and recorded in the ticket https://fedorahosted.org/sssd/ticket/2119 But in reality the cause was bug in the Unicode conversion and a bug with space processing.
0011-INI-Fix-processing-of-the-white-space-at-the-end-of-.patch 0012-INI-Unit-test-for-space-trimming-in-multiline-values.patch
----------------------------
The following patch adds more unit test for both Unicode conversion and folding by combining the tests together. The unit tests written for each of them individually are not sufficient to catch corner cases. This test does. And I played with different constants before checking in to make sure that all sorts of combinations are caught. I decided to settle on these numbers because they provide sufficient amount of testing but do not extend the time too much. Right now all make check tests take about 7-8 seconds on my laptop.
0013-INI-Adding-more-unit-tests.patch