On 29/11/12 15:33, Ariel Barria wrote:
Date: Thu, 29 Nov 2012 12:08:57 +0100 From: okos@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid
sssd.conf
On 28/11/12 19:31, Ariel Barria wrote:
Date: Wed, 28 Nov 2012 17:50:09 +0100 From: okos@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid
sssd.conf
On 28/11/12 17:12, Ariel Barria wrote:
Thanks for your comments.
Date: Wed, 28 Nov 2012 14:38:29 +0100 From: okos@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for
invalid
sssd.conf
On 28/11/12 01:31, Ariel Barria wrote: > https://fedorahosted.org/sssd/ticket/1625 > > / > // Additional info:/ > > ..../the class of configuration error messages could be > changed to match the default debug level./ > > Apparently this was covered with #1345 and in server.c > > / if (debug_level == SSSDBG_UNRESOLVED) { > /* set debug level if any in conf_entry */ > ret = confdb_get_int(ctx->confdb_ctx, conf_entry, > CONFDB_SERVICE_DEBUG_LEVEL, > SSSDBG_DEFAULT, > &debug_level);/ >
Hi Ariel,
Could you add the path of database to the > + DEBUG(SSSDBG_CRIT_FAILURE, ("Error loading configuration
file: "
> "[%d]: %s\n", ret, strerror(ret))); part as well? And error messages from strerror are not much help
in this
case [22]: Invalid argument // for empty file [2]: No such file or directory // for invalid syntax in
config file
so could you change this accordingly to ticket proposal ?
Thanks
Ondra >
Thanks for the patch, but now, there's a bit wide if-else statement, could you please rewrite it into swich? And append a commit message (what's been done and why)
sure, new patch.
Hi. true, I had not seen.
Hi Ariel,
Just remove multiple whitespaces:
DEBUG(SSSDBG_CRIT_FAILURE, ("Error loading configuration file %s: " " invalid configuration.\n", config_file));
--------^
DEBUG(SSSDBG_CRIT_FAILURE, ("Error loading configuration file %s: " " empty file.\n", config_file));
--------^
and add the link to the trac to commit message and its an Ack
Thanks
Ondra
-- Ondrej Kos Associate Software Engineer Identity Management Red Hat Czech
phone: +420-532-294-558 cell: +420-736-417-909 ext: 82-62558 loc: 1013 Brno 1 office irc: okos @ #brno _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Thanks for the patch
ACK
Ondra