[sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

pbrezina commented:
"""
On 11/03/2017 09:56 AM, fidencio wrote:
> *@fidencio* commented on this pull request.
>
> And I've also found something a little bit weird in the code.
>
> In src/providers/ipa/ipa_access.c
> https://github.com/SSSD/sssd/pull/424#discussion_r148730473:
> >    DEBUG(SSSDBG_CRIT_FAILURE, "Unable to create tevent request!\n");
>    return NULL;
> }
> subreq = ipa_fetch_hbac_send(state, params->ev, params->be_ctx, access_ctx);
> if (subreq == NULL) {
>    ret = ENOMEM;
>    goto done;
> }
> tevent_req_set_callback(subreq, ipa_refresh_access_rules_done, req);
> ret = EAGAIN;
>
> +done:
> if (ret == EOK) {
>
> I've failed to understand how ret == EOK can happen here.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> https://github.com/SSSD/sssd/pull/424#pullrequestreview-74019171, or
> mute the thread
> https://github.com/notifications/unsubscribe-auth/ARsIkvxIXeLpfXUPIj2k-RYji82skOyrks5sytU0gaJpZM4QEqrd.

It can't. It's a copy/paste error.

"""

See the full comment at https://github.com/SSSD/sssd/pull/424#issuecomment-341682921