[sssd PR#735][opened] sbus: do not use signature when copying dictionary entry

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/735
Author: pbrezina
 Title: #735: sbus: do not use signature when copying dictionary entry
Action: opened

PR body:
"""
When we open container for DBUS_TYPE_DICT_ENTRY, dbus expects the
signature to be NULL.

Reproducer:

1. Setup custom attributes
```
[ifp]
user_attributes = +test

[domain/ldap.vm]
...
ldap_user_extra_attrs = test:homeDirectory
```

2. Run SSSD and require those attributes for example with
```
sssctl user-checks user-1
```

3. SSSD will crash without the patch
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/735/head:pr735
git checkout pr735

[sssd PR#735][comment] sbus: do not use signature when copying dictionary entry

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/735
Title: #735: sbus: do not use signature when copying dictionary entry

pbrezina commented:
"""
Check `sbus_iterator_write_ifp_extra()` to see how in it written into the D-Bus message that later copied to the reply of `GetAll`.
"""

See the full comment at https://github.com/SSSD/sssd/pull/735#issuecomment-454753082

[sssd PR#735][comment] sbus: do not use signature when copying dictionary entry

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/735
Title: #735: sbus: do not use signature when copying dictionary entry

sumit-bose commented:
"""
Thanks, the patch is working fine for me.
"""

See the full comment at https://github.com/SSSD/sssd/pull/735#issuecomment-454760178

[sssd PR#735][comment] sbus: do not use signature when copying dictionary entry

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/735
Title: #735: sbus: do not use signature when copying dictionary entry

sumit-bose commented:
"""
Internal CI basically passed, there was a failure which imo is unrelated to your patch. ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/735#issuecomment-454797069

[sssd PR#735][+Accepted] sbus: do not use signature when copying dictionary entry

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/735
Title: #735: sbus: do not use signature when copying dictionary entry

Label: +Accepted

[sssd PR#735][comment] sbus: do not use signature when copying dictionary entry

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/735
Title: #735: sbus: do not use signature when copying dictionary entry

jhrozek commented:
"""
I opened upstream issue #3921 just so we track the fix somewhere (also downstream) and pushed the patch as bc1e8ffd5cca74aa8408c1c6bce0a3cf42a0974b
"""

See the full comment at https://github.com/SSSD/sssd/pull/735#issuecomment-455326698

[sssd PR#735][closed] sbus: do not use signature when copying dictionary entry

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/735
Author: pbrezina
 Title: #735: sbus: do not use signature when copying dictionary entry
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/735/head:pr735
git checkout pr735

[sssd PR#735][+Pushed] sbus: do not use signature when copying dictionary entry

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/735
Title: #735: sbus: do not use signature when copying dictionary entry

Label: +Pushed