[sssd PR#52][opened] CI: Remove dlopen-test from valgrind blacklist
by fidencio
URL: https://github.com/SSSD/sssd/pull/52
Author: lslebodn
Title: #52: CI: Remove dlopen-test from valgrind blacklist
Action: opened
PR body:
"""
Dlopen test was added to blacklist due to following reason:
> Disable running dlopen-tests under Valgrind as their use of dlclose
> makes Valgrind drop symbols and produce meaningless backtraces, which
> cannot be matched with specific suppressions.
It's true that dlclose makes meaningless backtraces but it can
catch real leaks.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/52/head:pr52
git checkout pr52
7 years, 6 months
[sssd PR#10][comment] UTIL: Remove support to libini older than 1.0.0
by fidencio
URL: https://github.com/SSSD/sssd/pull/10
Title: #10: UTIL: Remove support to libini older than 1.0.0
lslebodn commented:
"""
On (07/09/16 00:56), Jakub Hrozek wrote:
>On Tue, Sep 06, 2016 at 11:49:09AM -0700, lslebodn wrote:
>> IMHO, it might be better to close this PR.
>> If we decide to dor support for libini_config < 1.1 or 1.2
>> then it will be a different patch anyway. @see my previous comment
>
>The only reason I suggest deferred over closing is that if we close this
>PR, we will never remember to ressurect it. If it's going to be
>deferred, it will keep coming up in the PR list.
>
If we decide dro support for older version of libini_config
it will be higher version that 1.0 and therfore the patch
would be different.
Moreover, pull request are not tracking system.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/10#issuecomment-254719553
7 years, 6 months
[sssd PR#33][opened] SECRETS: Some small misc fixes + fixing #3136
by fidencio
URL: https://github.com/SSSD/sssd/pull/33
Author: fidencio
Title: #33: SECRETS: Some small misc fixes + fixing #3136
Action: opened
PR body:
"""
This series was made on top of Jakub's patches adding Secrets'
documentation, that is applied on top of my own patches adding
a the update-confdb-process.
The patches that needs to be reviewed are the last 6 patches, and
they're listed below:
f587a7c (Fabiano Fidêncio, 3 days ago)
SECRETS: Add a configurable depth limit for nested containers
Resolves: https://fedorahosted.org/sssd/ticket/3168
Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com>
e98bd63 (Fabiano Fidêncio, 7 hours ago)
SECRETS: Use a tmp_context on local_db_check_containers()
Otherwise the struct ldb_dn will be hanging on the mem_ctx till it gets
freed.
Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com>
4a90c20 (Fabiano Fidêncio, 7 hours ago)
SECRETS: Make functions from local.c static
There's no reason for those functions to be exposed.
Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com>
67e1301 (Fabiano Fidêncio, 10 hours ago)
CONFIG: Add secrets' provider option
The provider option specifies where should the secrets be stored.
Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com>
5de385f (Jakub Hrozek, 6 weeks ago)
CONFIG: List allowed secrets responder options
Co-author: Fabiano Fidêncio <fidencio(a)redhat.com>
1f51d50 (Fabiano Fidêncio, 11 hours ago)
CONFIG: Add secrets responder to the allowed sections
Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com>
In the last patch (f587a7c) I'm adding a test for the maximum depth,
but I decided to, at least for now, do this test based on the default
value set for this option instead of trying to implemenet something in
python to read the config entries from the ConfDB file.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/33/head:pr33
git checkout pr33
7 years, 6 months
