[sssd PR#918][comment] Add support for NSS hosts database lookup.
by alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/918
Title: #918: Add support for NSS hosts database lookup.
alexey-tikhonov commented:
"""
> @sumit-bose is there any way to trigger a new CI run? All tests are passing in my computer.
Hi,
I restarted PR CI.
But having a quick glance at results of previous run, there are some compilation errors like:
```
/shared/sssd/src/tests/cmocka/common_mock_resp_dp.c:66:1: error: conflicting types for 'sss_dp_resolver_get_send'
66 | sss_dp_resolver_get_send(TALLOC_CTX *mem_ctx,
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /shared/sssd/src/tests/cmocka/common_mock_resp_dp.c:24:
/shared/sssd/src/responder/common/responder.h:300:1: note: previous declaration of 'sss_dp_resolver_get_send' was here
300 | sss_dp_resolver_get_send(TALLOC_CTX *mem_ctx,
| ^~~~~~~~~~~~~~~~~~~~~~~~
```
"""
See the full comment at https://github.com/SSSD/sssd/pull/918#issuecomment-576594651
4 years, 3 months
[sssd PR#968][opened] util/sss_ptr_hash: fixed double free in sss_ptr_hash_delete_cb()
by alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/968
Author: alexey-tikhonov
Title: #968: util/sss_ptr_hash: fixed double free in sss_ptr_hash_delete_cb()
Action: opened
PR body:
"""
Calling data->callback(value->ptr) in sss_ptr_hash_delete_cb() could lead
to freeing of value->ptr and thus to destruction of value->spy that is
attached to value->ptr.
In turn sss_ptr_hash_spy_destructor() calls sss_ptr_hash_delete() ->
hash_delete() -> sss_ptr_hash_delete_cb() again and in this recursive
execution hash entry was actually deleted and value was freed.
When stack was unwound back to "first" sss_ptr_hash_delete_cb() it tried
to free value again => double free.
To prevent this bug value and hence spy are now freed before execution of
data->callback(value->ptr).
Resolves: https://pagure.io/SSSD/sssd/issue/4135
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/968/head:pr968
git checkout pr968
4 years, 3 months
[sssd PR#967][opened] util/watchdog: fixed watchdog implementation
by mzidek-rh
URL: https://github.com/SSSD/sssd/pull/967
Author: mzidek-rh
Title: #967: util/watchdog: fixed watchdog implementation
Action: opened
PR body:
"""
In case watchdog detected locked process and this process was parent
process it just sent SIGTERM to the whole group of processes, including
itself.
This handling was wrong: generic `server_setup()` installs custom
libtevent handler for SIGTERM signal so this signal is only processed
in the context of tevent mainloop. But if tevent mainloop is stuck
(exactly the case that triggers WD) then event is not processed
and this made watchdog useless.
`watchdog_handler()` and `watchdog_detect_timeshift()` were amended to do
unconditional `_exit()` after optionally sending a signal to the group.
Resolves: https://pagure.io/SSSD/sssd/issue/4089
Reviewed-by: Sumit Bose <sbose(a)redhat.com>
(cherry picked from commit 2c13d8bd00f1e8ff30e9fc81f183f6450303ac30)
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/967/head:pr967
git checkout pr967
4 years, 3 months