sssd-devel January 2020

sssd-devel@lists.fedorahosted.org

3 participants
31 discussions

[sssd PR#918][comment] Add support for NSS hosts database lookup.
by pbrezina 23 Jan '20

23 Jan '20

URL: https://github.com/SSSD/sssd/pull/918 Title: #918: Add support for NSS hosts database lookup. pbrezina commented: """ Thank you. I just gave it a quick look, especially the cache_req parts per Sumit's requests and all looks good to me. Though I haven't gone through all the patches thoroughly so I'll leave it for Sumit to ack it. """ See the full comment at https://github.com/SSSD/sssd/pull/918#issuecomment-577645234

1 0

[sssd PR#918][comment] Add support for NSS hosts database lookup.
by scabrero 21 Jan '20

21 Jan '20

URL: https://github.com/SSSD/sssd/pull/918 Title: #918: Add support for NSS hosts database lookup. scabrero commented: """ I didn't have cmoka installed and the file was not built. Everything is OK now. """ See the full comment at https://github.com/SSSD/sssd/pull/918#issuecomment-576674996

1 0

[sssd PR#918][comment] Add support for NSS hosts database lookup.
by alexey-tikhonov 21 Jan '20

21 Jan '20

URL: https://github.com/SSSD/sssd/pull/918 Title: #918: Add support for NSS hosts database lookup. alexey-tikhonov commented: """ > @sumit-bose is there any way to trigger a new CI run? All tests are passing in my computer. Hi, I restarted PR CI. But having a quick glance at results of previous run, there are some compilation errors like: ``` /shared/sssd/src/tests/cmocka/common_mock_resp_dp.c:66:1: error: conflicting types for 'sss_dp_resolver_get_send' 66 | sss_dp_resolver_get_send(TALLOC_CTX *mem_ctx, | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from /shared/sssd/src/tests/cmocka/common_mock_resp_dp.c:24: /shared/sssd/src/responder/common/responder.h:300:1: note: previous declaration of 'sss_dp_resolver_get_send' was here 300 | sss_dp_resolver_get_send(TALLOC_CTX *mem_ctx, | ^~~~~~~~~~~~~~~~~~~~~~~~ ``` """ See the full comment at https://github.com/SSSD/sssd/pull/918#issuecomment-576594651

1 0

[sssd PR#918][comment] Add support for NSS hosts database lookup.
by sumit-bose 21 Jan '20

21 Jan '20

URL: https://github.com/SSSD/sssd/pull/918 Title: #918: Add support for NSS hosts database lookup. sumit-bose commented: """ retest this, please """ See the full comment at https://github.com/SSSD/sssd/pull/918#issuecomment-576581393

1 0

[sssd PR#918][comment] Add support for NSS hosts database lookup.
by scabrero 21 Jan '20

21 Jan '20

URL: https://github.com/SSSD/sssd/pull/918 Title: #918: Add support for NSS hosts database lookup. scabrero commented: """ @sumit-bose is there any way to trigger a new CI run? All tests are passing in my computer. """ See the full comment at https://github.com/SSSD/sssd/pull/918#issuecomment-576578774

1 0

[sssd PR#968][opened] util/sss_ptr_hash: fixed double free in sss_ptr_hash_delete_cb()
by alexey-tikhonov 14 Jan '20

14 Jan '20

URL: https://github.com/SSSD/sssd/pull/968 Author: alexey-tikhonov Title: #968: util/sss_ptr_hash: fixed double free in sss_ptr_hash_delete_cb() Action: opened PR body: """ Calling data->callback(value->ptr) in sss_ptr_hash_delete_cb() could lead to freeing of value->ptr and thus to destruction of value->spy that is attached to value->ptr. In turn sss_ptr_hash_spy_destructor() calls sss_ptr_hash_delete() -> hash_delete() -> sss_ptr_hash_delete_cb() again and in this recursive execution hash entry was actually deleted and value was freed. When stack was unwound back to "first" sss_ptr_hash_delete_cb() it tried to free value again => double free. To prevent this bug value and hence spy are now freed before execution of data->callback(value->ptr). Resolves: https://pagure.io/SSSD/sssd/issue/4135 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/968/head:pr968 git checkout pr968

2 13

[sssd PR#905][opened] WIP: Don't ignore host entries in Group Policy security filters
by dmulder 14 Jan '20

14 Jan '20

URL: https://github.com/SSSD/sssd/pull/905 Author: dmulder Title: #905: WIP: Don't ignore host entries in Group Policy security filters Action: opened PR body: """ I'm posting my code here to hopefully receive some feedback while I work on host entries in gpo security filters. Any feedback/criticism is welcome! Finished: Validate against host sid in ad_gpo_evaluate_dacl(), also test. In progress: Host sid retrieval via sdap. TODO: Caching host sid in sysdb. Test sdap search for host sid. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/905/head:pr905 git checkout pr905

6 45

[sssd PR#967][opened] util/watchdog: fixed watchdog implementation
by mzidek-rh 14 Jan '20

14 Jan '20

URL: https://github.com/SSSD/sssd/pull/967 Author: mzidek-rh Title: #967: util/watchdog: fixed watchdog implementation Action: opened PR body: """ In case watchdog detected locked process and this process was parent process it just sent SIGTERM to the whole group of processes, including itself. This handling was wrong: generic `server_setup()` installs custom libtevent handler for SIGTERM signal so this signal is only processed in the context of tevent mainloop. But if tevent mainloop is stuck (exactly the case that triggers WD) then event is not processed and this made watchdog useless. `watchdog_handler()` and `watchdog_detect_timeshift()` were amended to do unconditional `_exit()` after optionally sending a signal to the group. Resolves: https://pagure.io/SSSD/sssd/issue/4089 Reviewed-by: Sumit Bose <sbose(a)redhat.com> (cherry picked from commit 2c13d8bd00f1e8ff30e9fc81f183f6450303ac30) """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/967/head:pr967 git checkout pr967

3 12

[sssd PR#969][opened] ad: add ad_use_ldaps (sssd-1-16)
by sumit-bose 14 Jan '20

14 Jan '20

URL: https://github.com/SSSD/sssd/pull/969 Author: sumit-bose Title: #969: ad: add ad_use_ldaps (sssd-1-16) Action: opened PR body: """ With this new boolean option the AD provider should only use the LDAPS port 636 and the Global Catalog port 3629 which is TLS protected as well. Related to https://pagure.io/SSSD/sssd/issue/4131 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/969/head:pr969 git checkout pr969

2 8

[sssd PR#966][opened] ad: add ad_use_ldaps
by sumit-bose 13 Jan '20

13 Jan '20

URL: https://github.com/SSSD/sssd/pull/966 Author: sumit-bose Title: #966: ad: add ad_use_ldaps Action: opened PR body: """ With this new boolean option the AD provider should only use the LDAPS port 636 and the Global Catalog port 3629 which is TLS protected as well. Related to https://pagure.io/SSSD/sssd/issue/4131 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/966/head:pr966 git checkout pr966

3 17

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel January 2020