On Fri, Jan 25, 2013 at 05:38:25PM +0100, Michal Židek wrote:
On 01/25/2013 04:52 PM, Sumit Bose wrote:
On Fri, Jan 25, 2013 at 04:12:38PM +0100, Michal Židek wrote:
Bug found by coverity. https://fedorahosted.org/sssd/ticket/1790
Patch is attached.
Thanks Michal
sorry, there are missing braces:
DEBUG(SSSDBG_CRIT_FAILURE, "talloc_zero() failed.\n");
DEBUG(SSSDBG_CRIT_FAILURE, ("talloc_zero() failed.\n"));
This was fixed in the patch I sent recently :-)
Although it is right that the original cause is that talloc_zero() failed in be_req_create() I think it is better to say "be_req_create() failed." here, because implementation of be_req_create() might change.
You are right. I used the message because we use it on other places were be_req_create() is called. Attached patch uses the message you proposed.
Thank you, ACK.
bye, Sumit