On Thu, Jul 25, 2013 at 01:30:25PM +0200, Lukas Slebodnik wrote:
ehlo,
Commit bfd59d1a2d0d45125e5164ef12c425690d519f61 introduced new Coverity issue. In case of failure, variable group_name can be used uninitialized in DEBUG macro.
# DEBUG(SSSDBG_MINOR_FAILURE, # ("Failed to save group [%s]: [%s]\n", #- name ? name : "Unknown", #+ group_name ? group_name : "Unknown", ^^^^^^^^^^ uninit_use: Using uninitialized value "group_name". # strerror(ret)));
Before this commit, variable name was used in the same place and variable name was initialized to NULL.
I suppose that we should run coverity scan in the review proces (either automatically patchwork??? or manually)
Yes, and I was running some of the larger patches (the 1.11 beta1 patchset for example) through Coverity already, but this one seemed simple enough. Well, it wasn't..
Patch is attached.
ACK
LS