URL:
https://github.com/SSSD/sssd/pull/411
Title: #411: AD: Remember last site discovered
fidencio commented:
"""
@pbrezina, from a quick look in the code (no tests have been done on my side) there's
something that bothers me a little bit.
This part of the code:
```
+ /* Remember current site so it can be used during next lookup so
+ * we can contact directory controllers within a known reachable
+ * site first. */
+ ret = ad_srv_plugin_ctx_switch_site(state->ctx, state->site);
+ if (ret != EOK) {
+ DEBUG(SSSDBG_CRIT_FAILURE, "Unable to set site [%d]: %s\n",
+ ret, sss_strerror(ret));
+ goto done;
+ }
```
Although I'd raise a loud debug message, I personally wouldn't fail
ad_srv_plugin_site_done() because of a ad_srv_plugin_ctx_switch_site() failure.
Keep in mind that I don't have any strong feelings about what will be your preference.
(IOW, feel free to ignore this comment).
"""
See the full comment at
https://github.com/SSSD/sssd/pull/411#issuecomment-337614191