[sssd PR#200][opened] Improve PAM test client

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/200
Author: sumit-bose
 Title: #200: Improve PAM test client
Action: opened

PR body:
"""
This patch set makes the PAM test client more flexible and adds additional
lookups of the user via NSS and InfoPipe.

For simplicity this version uses libsss_simpleifp to access InfoPipe. A later
version might use libdbus directly to reduce the number of dependencies.

Related to https://pagure.io/SSSD/sssd/issue/3292
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/200/head:pr200
git checkout pr200

[sssd PR#200][comment] Improve PAM test client

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

lslebodn commented:
"""
I thought that new "tools" command should be part of sssctl.

If it is very omplicate to convert then we might use the same approach as git
with subcommands sssctl-pam_test_client

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-287713790

[sssd PR#200][comment] Improve PAM test client

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

sumit-bose commented:
"""
I agree. But I wanted to get some feedback from people who asked for such testing tool first before adding the functionality to the "official" sssctl utility. Because chances are that some changes are requested I wanted to avoid that the sssctl interface of the tools must be changed in the next release again.

But if you prefer I can try to add it to sssctl as well.
"""

See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-287722328

[sssd PR#200][comment] Improve PAM test client

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

jhrozek commented:
"""
I'm fine with adding this form to master now and asking for feedback in downstream as long as we agree that the functionality must be part of sssctl before the next upstream release (similar arrangement as we have with the certmapping tool I guess..)
"""

See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-288352619

[sssd PR#200][comment] Improve PAM test client

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

lslebodn commented:
"""
On (22/03/17 03:08), Jakub Hrozek wrote:
> I'm fine with adding this form to master now and asking for feedback in downstream as long as we agree that the functionality must be part of sssctl before the next upstream release (similar arrangement as we have with the certmapping tool I guess..)

I do no understand this; which feedback do you mean?

We can prepare version with sssctl; then get feedback from anyone
Update functionality based on feedback.

Is there any problem with such approach ?

IMHO it would be just confusing if we move it to sssctl subcomand later.

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-288373471

[sssd PR#200][synchronized] Improve PAM test client

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/200
Author: sumit-bose
 Title: #200: Improve PAM test client
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/200/head:pr200
git checkout pr200

[sssd PR#200][comment] Improve PAM test client

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

sumit-bose commented:
"""
The new version integrated pam_test_client into sssctl in the last patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-290513921

[sssd PR#200][comment] Improve PAM test client

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

sumit-bose commented:
"""
A successful CI run can be found at http://sssd-ci.duckdns.org/logs/job/66/81/summary.html.
"""

See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-290515031

[sssd PR#200][comment] Improve PAM test client

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

pbrezina commented:
"""
Patches looks good, I have only one comment: we should use gettext when printing messages to user.
"""

See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-292477580

[sssd PR#200][comment] Improve PAM test client

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

pbrezina commented:
"""
And maybe a little cosmetic stuff, can we add some empty lines to easier differentiate output blocks?

```
user: user-1
action: auth
service: system-auth
SSSD nss user lookup result:
 - user name: user-1
 - user id: 10001
 - group id: 10001
 - gecos: user-1
 - home directory: /home/user-1
 - shell: 
SSSD InfoPipe user lookup result:
 - name: user-1
 - uidNumber: 10001
 - gidNumber: 10001
 - gecos: user-1
 - homeDirectory: /home/user-1
 - loginShell: 
testing pam_authenticate
Password: 
pam_authenticate: Authentication failure
PAM Environment:
 - no env -
```
==>
```
user: user-1
action: auth
service: system-auth

SSSD nss user lookup result:
 - user name: user-1
 - user id: 10001
 - group id: 10001
 - gecos: user-1
 - home directory: /home/user-1
 - shell:

SSSD InfoPipe user lookup result:
 - name: user-1
 - uidNumber: 10001
 - gidNumber: 10001
 - gecos: user-1
 - homeDirectory: /home/user-1
 - loginShell:

testing pam_authenticate

Password: 
pam_authenticate: Authentication failure

PAM Environment:
 - no env -
```

"""

See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-292478501

[sssd PR#200][synchronized] Improve PAM test client

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/200
Author: sumit-bose
 Title: #200: Improve PAM test client
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/200/head:pr200
git checkout pr200

[sssd PR#200][synchronized] Improve PAM test client

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/200
Author: sumit-bose
 Title: #200: Improve PAM test client
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/200/head:pr200
git checkout pr200

[sssd PR#200][comment] Improve PAM test client

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

sumit-bose commented:
"""
Thank you for the review, all your suggestions are included in the latest update. To really make use of gettext I added the sssctl source files to POTFILES.in in a new patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-292523343

[sssd PR#200][comment] Improve PAM test client

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

pbrezina commented:
"""
Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-292923387

[sssd PR#200][+Pushed] Improve PAM test client

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

Label: +Pushed

[sssd PR#200][closed] Improve PAM test client

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/200
Author: sumit-bose
 Title: #200: Improve PAM test client
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/200/head:pr200
git checkout pr200

[sssd PR#200][comment] Improve PAM test client

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client

lslebodn commented:
"""
master:
* dbeae483464e42238a84c6a5b8c3c4f5312ae643
* 4a9160e2b3b9c531e2b4a7884f49bfbb4a07a992
* 9be97c9cc69e5e6e568d7e21f61a46c3ae2dc387
* 40ff10d73063949ca699670ca212e96b809d5fcd
* 435b3678de25d22eb8a6e892109d26c32f0760a4
* 7be6624d9eda369e9a4d70c8ee4939b3622229b3
"""

See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-292952641