6:25 a.m.
URL: https://github.com/SSSD/sssd/pull/857
Author: jhrozek
Title: #857: Don't qualify users from files domain when default_domain_suffix is set
Action: opened
PR body:
"""
Resolves: https://pagure.io/SSSD/sssd/issue/4052
The files domain should always be non-qualified. The usual rules like
qualification of all domains except the one set with default_domain_suffix
should not apply.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/857/head:pr857
git checkout pr857
8:16 a.m.
New subject: [sssd PR#857][comment] Don't qualify users from files domain when default_domain_suffix is set
URL: https://github.com/SSSD/sssd/pull/857
Title: #857: Don't qualify users from files domain when default_domain_suffix is set
mzidek-rh commented:
"""
I have not tested the patch yet (LGTM so far), but IMO the default_domain_suffix man page
should mention the exception in behavior for files domain.
"""
See the full comment at https://github.com/SSSD/sssd/pull/857#issuecomment-519513153
8:16 a.m.
New subject: [sssd PR#857][+Changes requested] Don't qualify users from files domain when default_domain_suffix is set
URL: https://github.com/SSSD/sssd/pull/857
Title: #857: Don't qualify users from files domain when default_domain_suffix is set
Label: +Changes requested
2:53 p.m.
New subject: [sssd PR#857][synchronized] Don't qualify users from files domain when default_domain_suffix is set
URL: https://github.com/SSSD/sssd/pull/857
Author: jhrozek
Title: #857: Don't qualify users from files domain when default_domain_suffix is set
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/857/head:pr857
git checkout pr857
2:55 p.m.
New subject: [sssd PR#857][comment] Don't qualify users from files domain when default_domain_suffix is set
URL: https://github.com/SSSD/sssd/pull/857
Title: #857: Don't qualify users from files domain when default_domain_suffix is set
jhrozek commented:
"""
Thanks @mzidek-rh for the review. How about now?
"""
See the full comment at https://github.com/SSSD/sssd/pull/857#issuecomment-519664632
2:55 p.m.
New subject: [sssd PR#857][-Changes requested] Don't qualify users from files domain when default_domain_suffix is set
URL: https://github.com/SSSD/sssd/pull/857
Title: #857: Don't qualify users from files domain when default_domain_suffix is set
Label: -Changes requested
5:11 p.m.
New subject: [sssd PR#857][comment] Don't qualify users from files domain when default_domain_suffix is set
URL: https://github.com/SSSD/sssd/pull/857
Title: #857: Don't qualify users from files domain when default_domain_suffix is set
mzidek-rh commented:
"""
Works for me. ACK.
"""
See the full comment at https://github.com/SSSD/sssd/pull/857#issuecomment-521028720
5:12 p.m.
New subject: [sssd PR#857][+Accepted] Don't qualify users from files domain when default_domain_suffix is set
URL: https://github.com/SSSD/sssd/pull/857
Title: #857: Don't qualify users from files domain when default_domain_suffix is set
Label: +Accepted
7:11 a.m.
New subject: [sssd PR#857][comment] Don't qualify users from files domain when default_domain_suffix is set
URL: https://github.com/SSSD/sssd/pull/857
Title: #857: Don't qualify users from files domain when default_domain_suffix is set
jhrozek commented:
"""
* master: 41da9ddfd084024ba9ca20b6d3c0b531c0473231
"""
See the full comment at https://github.com/SSSD/sssd/pull/857#issuecomment-521220284
7:11 a.m.
New subject: [sssd PR#857][closed] Don't qualify users from files domain when default_domain_suffix is set
URL: https://github.com/SSSD/sssd/pull/857
Author: jhrozek
Title: #857: Don't qualify users from files domain when default_domain_suffix is set
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/857/head:pr857
git checkout pr857
1717
days inactive
1729
days old
sssd-devel@lists.fedorahosted.org
9 comments
2 participants
participants (2)
-
jhrozek -
mzidek-rh