10:52 a.m.
URL: https://github.com/SSSD/sssd/pull/194
Author: mzidek-rh
Title: #194: config-check: Message when sssd.conf is missing
Action: opened
PR body:
"""
sssctl config-check should print a message for user
if no sssd.conf was found.
Resolves:
https://pagure.io/SSSD/sssd/issue/3330
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/194/head:pr194
git checkout pr194
10:57 a.m.
New subject: [sssd PR#194][comment] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
mzidek-rh commented:
"""
To test just remove the sssd.conf file and do sssctl config-check.
"""
See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286467249
11:18 a.m.
New subject: [sssd PR#194][comment] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
celestian commented:
"""
LGTM and I pushed it to CI test.
"""
See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286474277
11:24 a.m.
New subject: [sssd PR#194][synchronized] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Author: mzidek-rh
Title: #194: config-check: Message when sssd.conf is missing
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/194/head:pr194
git checkout pr194
11:52 a.m.
New subject: [sssd PR#194][comment] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
lslebodn commented:
"""
There are few inline comments
"""
See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286485973
11:58 a.m.
New subject: [sssd PR#194][synchronized] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Author: mzidek-rh
Title: #194: config-check: Message when sssd.conf is missing
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/194/head:pr194
git checkout pr194
11:59 a.m.
New subject: [sssd PR#194][comment] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
mzidek-rh commented:
"""
I agree with the comments. See new version pushed.
"""
See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286488429
12:14 p.m.
New subject: [sssd PR#194][synchronized] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Author: mzidek-rh
Title: #194: config-check: Message when sssd.conf is missing
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/194/head:pr194
git checkout pr194
12:14 p.m.
New subject: [sssd PR#194][comment] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
mzidek-rh commented:
"""
New version attached.
"""
See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286493411
12:17 p.m.
New subject: [sssd PR#194][comment] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
mzidek-rh commented:
"""
On 03/14/2017 06:08 PM, lslebodn wrote:
*@lslebodn* commented on this pull request.
------------------------------------------------------------------------
In src/tools/sssctl/sssctl_config.c
<https://github.com/SSSD/sssd/pull/194#discussion_r105969388>;:
> @@ -63,7 +63,10 @@ errno_t sssctl_config_check(struct sss_cmdline *cmdline,
/* Open config file */
ret = sss_ini_config_file_open(init_data, SSSD_CONFIG_FILE);
- if (ret != EOK) {
+ if (ret == ENOENT) {
+ ERROR("File "SSSD_CONFIG_FILE" does not exist.\n");
Sorry for nitpicking but it is not very user-friendly for translators.
On other places we use |"%1$s"|. Check src/tools/sss_useradd.c
Thanks for catching this. I did not realize that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/SSSD/sssd/pull/194#pullrequestreview-26871471>;, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AUp9WKAKVTryWZGLuC6tSIk...;.
"""
See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286494143
2:32 p.m.
New subject: [sssd PR#194][comment] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
lslebodn commented:
"""
BTW; I've just realized that missing configuration file is not a problem since commit
a4837791f62283079e7be4b17efb769be8b2dfd1.
@jhrozek Do we want this patch just in 1.14?
"""
See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286534579
3:22 p.m.
New subject: [sssd PR#194][comment] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
jhrozek commented:
"""
if this patch is already written and you'd ack it otherwise then yes.
"""
See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286547773
6:05 a.m.
New subject: [sssd PR#194][comment] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
mzidek-rh commented:
"""
I know this is a corner case, but I would like sssctl config-check to behave more user
friendly in the case when config file is missing for whatever reason, it is just weird
when it says nothing and fails silently.
"""
See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286710098
6:21 a.m.
New subject: [sssd PR#194][comment] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
lslebodn commented:
"""
On (15/03/17 04:05), mzidek-rh wrote:
I know this is a corner case, but I would like sssctl config-check to
behave more user friendly in the case when config file is missing for whatever reason, it
is just weird when it says nothing and fails silently.
Sure; patch is fine for 1.14
We probably want different message for 1.15.
Because in 1.15 missing file is not critical; it is valid use-case.
So "sssctl config-check" should not fail.
But on the other hand there is nothing to validate.
ACK for current version in 1.14; but I will not close the ticket.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286713429
6:31 a.m.
New subject: [sssd PR#194][comment] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
lslebodn commented:
"""
sssd-1-14:
* b35d7aa90b18ba544ba11fcabeb9662e38fb91fa
"""
See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286715379
6:31 a.m.
New subject: [sssd PR#194][closed] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Author: mzidek-rh
Title: #194: config-check: Message when sssd.conf is missing
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/194/head:pr194
git checkout pr194
6:31 a.m.
New subject: [sssd PR#194][+Pushed] config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/194
Title: #194: config-check: Message when sssd.conf is missing
Label: +Pushed
2660
days inactive
2661
days old
sssd-devel@lists.fedorahosted.org
16 comments
4 participants
participants (4)
-
celestian -
jhrozek
-
lslebodn
-
mzidek-rh