5 a.m.
ehlo,
The first patch fixes regression introduced in 1.13.2.
https://fedorahosted.org/sssd/ticket/2493
I'm sorry I didn't catch it in review.
Fortunatelly there is a simple but annoying workaround.
Change user to "non-root" + remove old log files.
The second patch should fix ticket #2493 in different way.
LS
6:55 a.m.
New subject: [PATCH] Revert "DEBUG: Preventing chown_debug_file if journald on"
On (25/01/16 12:00), Lukas Slebodnik wrote:
ehlo,
The first patch fixes regression introduced in 1.13.2.
https://fedorahosted.org/sssd/ticket/2493
I'm sorry I didn't catch it in review.
Fortunatelly there is a simple but annoying workaround.
Change user to "non-root" + remove old log files.
The second patch should fix ticket #2493 in different way.
LS
Bump.
It would be good to fix a regression.
a
5:49 a.m.
New subject: [PATCH] Revert "DEBUG: Preventing chown_debug_file if journald on"
On (17/02/16 13:55), Lukas Slebodnik wrote:
On (25/01/16 12:00), Lukas Slebodnik wrote:
>ehlo,
>
>The first patch fixes regression introduced in 1.13.2.
>https://fedorahosted.org/sssd/ticket/2493
>
>I'm sorry I didn't catch it in review.
>Fortunatelly there is a simple but annoying workaround.
>
>Change user to "non-root" + remove old log files.
>
>The second patch should fix ticket #2493 in different way.
>
>LS
Bump.
It would be good to fix a regression.
Bump
LS
6:16 a.m.
New subject: [PATCH] Revert "DEBUG: Preventing chown_debug_file if journald on"
On Tue, Feb 23, 2016 at 12:49:34PM +0100, Lukas Slebodnik wrote:
On (17/02/16 13:55), Lukas Slebodnik wrote:
>On (25/01/16 12:00), Lukas Slebodnik wrote:
>>ehlo,
>>
>>The first patch fixes regression introduced in 1.13.2.
>>https://fedorahosted.org/sssd/ticket/2493
>>
>>I'm sorry I didn't catch it in review.
>>Fortunatelly there is a simple but annoying workaround.
>>
>>Change user to "non-root" + remove old log files.
>>
>>The second patch should fix ticket #2493 in different way.
>>
>>LS
>Bump.
>
>It would be good to fix a regression.
Bump
I have these patches on my todo list, but if anyone else already
started, just ping me on IRC..
8:33 a.m.
New subject: [PATCH] Revert "DEBUG: Preventing chown_debug_file if journald on"
On Mon, Jan 25, 2016 at 12:00:11PM +0100, Lukas Slebodnik wrote:
ehlo,
The first patch fixes regression introduced in 1.13.2.
https://fedorahosted.org/sssd/ticket/2493
I'm sorry I didn't catch it in review.
Fortunatelly there is a simple but annoying workaround.
Change user to "non-root" + remove old log files.
The second patch should fix ticket #2493 in different way.
LS
I just wonder if it makes sense to print an INTERNAL DEBUG message to
make it clear we went through that codepath, but otherwise ACK.
I like when bugs are fixed with removal of code :)
9:11 a.m.
New subject: [PATCH] Revert "DEBUG: Preventing chown_debug_file if journald on"
On (23/02/16 15:33), Jakub Hrozek wrote:
On Mon, Jan 25, 2016 at 12:00:11PM +0100, Lukas Slebodnik wrote:
> ehlo,
>
> The first patch fixes regression introduced in 1.13.2.
> https://fedorahosted.org/sssd/ticket/2493
>
> I'm sorry I didn't catch it in review.
> Fortunatelly there is a simple but annoying workaround.
>
> Change user to "non-root" + remove old log files.
>
> The second patch should fix ticket #2493 in different way.
>
> LS
I just wonder if it makes sense to print an INTERNAL DEBUG message to
make it clear we went through that codepath, but otherwise ACK.
This message would be logged very often in case of
logging to journal and empty directory /var/log/sssd.
IMHO it woudl be just a confusing debug message
even though it would be logged with high debug level.
LS
2:13 p.m.
New subject: [PATCH] Revert "DEBUG: Preventing chown_debug_file if journald on"
On Tue, Feb 23, 2016 at 04:11:14PM +0100, Lukas Slebodnik wrote:
On (23/02/16 15:33), Jakub Hrozek wrote:
>On Mon, Jan 25, 2016 at 12:00:11PM +0100, Lukas Slebodnik wrote:
>> ehlo,
>>
>> The first patch fixes regression introduced in 1.13.2.
>> https://fedorahosted.org/sssd/ticket/2493
>>
>> I'm sorry I didn't catch it in review.
>> Fortunatelly there is a simple but annoying workaround.
>>
>> Change user to "non-root" + remove old log files.
>>
>> The second patch should fix ticket #2493 in different way.
>>
>> LS
>
>I just wonder if it makes sense to print an INTERNAL DEBUG message to
>make it clear we went through that codepath, but otherwise ACK.
>
This message would be logged very often in case of
logging to journal and empty directory /var/log/sssd.
IMHO it woudl be just a confusing debug message
even though it would be logged with high debug level.
LS
Good point. ACK; CI:
http://sssd-ci.duckdns.org/logs/job/37/79/summary.html
2:58 p.m.
New subject: [PATCH] Revert "DEBUG: Preventing chown_debug_file if journald on"
On Tue, Feb 23, 2016 at 09:13:39PM +0100, Jakub Hrozek wrote:
On Tue, Feb 23, 2016 at 04:11:14PM +0100, Lukas Slebodnik wrote:
> On (23/02/16 15:33), Jakub Hrozek wrote:
> >On Mon, Jan 25, 2016 at 12:00:11PM +0100, Lukas Slebodnik wrote:
> >> ehlo,
> >>
> >> The first patch fixes regression introduced in 1.13.2.
> >> https://fedorahosted.org/sssd/ticket/2493
> >>
> >> I'm sorry I didn't catch it in review.
> >> Fortunatelly there is a simple but annoying workaround.
> >>
> >> Change user to "non-root" + remove old log files.
> >>
> >> The second patch should fix ticket #2493 in different way.
> >>
> >> LS
> >
> >I just wonder if it makes sense to print an INTERNAL DEBUG message to
> >make it clear we went through that codepath, but otherwise ACK.
> >
> This message would be logged very often in case of
> logging to journal and empty directory /var/log/sssd.
>
> IMHO it woudl be just a confusing debug message
> even though it would be logged with high debug level.
>
> LS
Good point. ACK; CI:
http://sssd-ci.duckdns.org/logs/job/37/79/summary.html
* master:
* 211539459651cbfb0cb03c800ce876c20420a195
* 74cc3797e311fd5dc12473678f499041ade7784f
* sssd-1-13:
* 9f1186e7be7ece4d2b9bbbe444d3fc42ab57b808
* cbb04b9439d73fff027e193093a49cdac3cdb499
2992
days inactive
3021
days old
sssd-devel@lists.fedorahosted.org
7 comments
2 participants
participants (2)
-
Jakub Hrozek -
Lukas Slebodnik