2:52 p.m.
URL: https://github.com/SSSD/sssd/pull/1002
Author: alexey-tikhonov
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Action: opened
PR body:
"""
Fixed "off-by-one error" in `reconnection_retries` interpretation.
Resolves: https://pagure.io/SSSD/sssd/issue/4168
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1002/head:pr1002
git checkout pr1002
4:37 p.m.
New subject: [sssd PR#1002][+Waiting for review] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Label: +Waiting for review
6:47 a.m.
New subject: [sssd PR#1002][-Waiting for review] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Label: -Waiting for review
6:47 a.m.
New subject: [sssd PR#1002][+Changes requested] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Label: +Changes requested
6:48 a.m.
New subject: [sssd PR#1002][comment] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
mzidek-gh commented:
"""
Adding changes requested for now. But as I said I do not insist on the change, so just
tell me if you disagree.
"""
See the full comment at https://github.com/SSSD/sssd/pull/1002#issuecomment-598144344
5:59 a.m.
New subject: [sssd PR#1002][comment] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
alexey-tikhonov commented:
"""
Hi Michal,
Would it not be better to use goto done and increase the
conn->retries++ at the end of the function (before leaving?)
```
done:
conn->retries++;
return ret;
```
I do not insist on this, but at least for me the code reads more natural that way. What
do you think?
This is 1-16 branch, and my understanding is that at this moment we only want bug fixes
here, not general improvements / code refactoring. Thus I think it is preferable to keep
patch as small as possible.
Regarding the substance of your question... I personally do not see great advantage in
using "goto" here but it is really matter of taste, I think.
So I would prefer to keep patch as it is - small one-liner.
"""
See the full comment at https://github.com/SSSD/sssd/pull/1002#issuecomment-598666897
6 a.m.
New subject: [sssd PR#1002][-Changes requested] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Label: -Changes requested
6 a.m.
New subject: [sssd PR#1002][+Waiting for review] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Label: +Waiting for review
8:27 a.m.
New subject: [sssd PR#1002][comment] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
mzidek-gh commented:
"""
Hi Michal,
> Would it not be better to use goto done and increase the conn->retries++ at the
end of the function (before leaving?)
> ```
> done:
> conn->retries++;
> return ret;
> ```
>
>
> I do not insist on this, but at least for me the code reads more natural that way.
What do you think?
This is 1-16 branch, and my understanding is that at this moment we only want bug fixes
here, not general improvements / code refactoring. Thus I think it is preferable to keep
patch as small as possible.
Regarding the substance of your question... I personally do not see great advantage in
using "goto" here but it is really matter of taste, I think.
So I would prefer to keep patch as it is - small one-liner.
Ok.
I have no other concerns.
ACK.
"""
See the full comment at https://github.com/SSSD/sssd/pull/1002#issuecomment-598719181
8:27 a.m.
New subject: [sssd PR#1002][+Accepted] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Label: +Accepted
8:27 a.m.
New subject: [sssd PR#1002][-Waiting for review] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Label: -Waiting for review
10:34 a.m.
New subject: [sssd PR#1002][+Ready to push] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Label: +Ready to push
10:45 a.m.
New subject: [sssd PR#1002][comment] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
pbrezina commented:
"""
* `sssd-1-16`
* a1bdab36e2c6fd6feeffd623a52d457926d80523 - SBUS: fixed off-by-one error" in
sbus_auto_reconnect()
"""
See the full comment at https://github.com/SSSD/sssd/pull/1002#issuecomment-599609157
10:45 a.m.
New subject: [sssd PR#1002][+Pushed] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Label: +Pushed
10:45 a.m.
New subject: [sssd PR#1002][-Accepted] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Label: -Accepted
10:45 a.m.
New subject: [sssd PR#1002][-Ready to push] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Label: -Ready to push
10:45 a.m.
New subject: [sssd PR#1002][closed] SBUS: fixed off-by-one error" in sbus_auto_reconnect()
URL: https://github.com/SSSD/sssd/pull/1002
Author: alexey-tikhonov
Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1002/head:pr1002
git checkout pr1002
1502
days inactive
1508
days old
sssd-devel@lists.fedorahosted.org
16 comments
3 participants
participants (3)
-
alexey-tikhonov -
mzidek-gh
-
pbrezina