Title: #1002: SBUS: fixed off-by-one error" in sbus_auto_reconnect()
Would it not be better to use goto done and increase the
conn->retries++ at the end of the function (before leaving?)
I do not insist on this, but at least for me the code reads more natural that way. What
do you think?
This is 1-16 branch, and my understanding is that at this moment we only want bug fixes
here, not general improvements / code refactoring. Thus I think it is preferable to keep
patch as small as possible.
Regarding the substance of your question... I personally do not see great advantage in
using "goto" here but it is really matter of taste, I think.
So I would prefer to keep patch as it is - small one-liner.
See the full comment at https://github.com/SSSD/sssd/pull/1002#issuecomment-598666897