[sssd PR#5248][opened] Enable exclude functionality in sssd session recording configuration
URL: https://github.com/SSSD/sssd/pull/5248 Author: justin-stephenson Title: #5248: Enable exclude functionality in sssd session recording configuration Action: opened
PR body: """ This is a fix for https://github.com/SSSD/sssd/issues/5089
This PR adds support for two new options in the sssd session recording configuration, to be applied only when `scope=all` is set:
* **exclude_users** * **exclude_groups**
I separated out each commit logically, to hopefully make the review easier but I am happy to squash any commits together as needed. I updated the relevant codepaths based on my review of https://github.com/SSSD/sssd/pull/136 so please let me know if I missed anything.
With this PR, responders will read the sessionRecording attribute when `scope=all` or `scope-some` to determine if recording should be enabled. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5248/head:pr5248 git checkout pr5248
URL: https://github.com/SSSD/sssd/pull/5248 Author: justin-stephenson Title: #5248: Enable exclude functionality in sssd session recording configuration Action: edited
Changed field: body Original value: """ This is a fix for https://github.com/SSSD/sssd/issues/5089
This PR adds support for two new options in the sssd session recording configuration, to be applied only when `scope=all` is set:
* **exclude_users** * **exclude_groups**
I separated out each commit logically, to hopefully make the review easier but I am happy to squash any commits together as needed. I updated the relevant codepaths based on my review of https://github.com/SSSD/sssd/pull/136 so please let me know if I missed anything.
With this PR, responders will read the sessionRecording attribute when `scope=all` or `scope-some` to determine if recording should be enabled. """
URL: https://github.com/SSSD/sssd/pull/5248 Title: #5248: Enable exclude functionality in sssd session recording configuration
pbrezina commented: """ New options needs to be added also to: src/config/SSSDConfig/sssdoptions.py Also pep8 tests fails: https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5248/1/fedora32/ci-pep8.log
Otherwise it looks good to me (I did not test it yet). """
See the full comment at https://github.com/SSSD/sssd/pull/5248#issuecomment-661799378
URL: https://github.com/SSSD/sssd/pull/5248 Author: justin-stephenson Title: #5248: Enable exclude functionality in sssd session recording configuration Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5248/head:pr5248 git checkout pr5248
URL: https://github.com/SSSD/sssd/pull/5248 Title: #5248: Enable exclude functionality in sssd session recording configuration
justin-stephenson commented: """ Those issues should now be fixed, thank you. """
See the full comment at https://github.com/SSSD/sssd/pull/5248#issuecomment-661929956
URL: https://github.com/SSSD/sssd/pull/5248 Title: #5248: Enable exclude functionality in sssd session recording configuration
pbrezina commented: """ Ack. Thank you. """
See the full comment at https://github.com/SSSD/sssd/pull/5248#issuecomment-678148956
URL: https://github.com/SSSD/sssd/pull/5248 Title: #5248: Enable exclude functionality in sssd session recording configuration
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5248 Title: #5248: Enable exclude functionality in sssd session recording configuration
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5248 Author: justin-stephenson Title: #5248: Enable exclude functionality in sssd session recording configuration Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5248/head:pr5248 git checkout pr5248
URL: https://github.com/SSSD/sssd/pull/5248 Title: #5248: Enable exclude functionality in sssd session recording configuration
pbrezina commented: """ * `master` * 733cafd72ee61cee34980da5825b5c09225e1b0f - MAN: Add SR exclude_users and exclude_groups options * d947ac7aff2e56c87347d41744b51edee8e13393 - INTG: Add session recording exclude tests * 19602d9a8e2e47e668e80d559f2a5a6af3cf97a6 - CACHE_REQ: Support SR exclude options * c51a9f6be14aa1ac5b5b685b11394488bf7fb685 - DP: Support SR excludes in initgroups postprocessing * 3a3be1cba1522fc43c2f174aff299b5901d9c4a7 - PAM: Rely on sessionRecording attribute * 38df7a3bbb872833c8f5278f055008a7c7fe95cd - NSS: Rely on sessionRecording attribute * 0049ec8554f489414069ffbfde693fc9577db602 - UTIL: Add support for SR exclude_users exclude_groups * a4af77e08bfa967ba21b789270681e29cc2f370a - CONFIG: Add SR exclude_users exclude_groups options """
See the full comment at https://github.com/SSSD/sssd/pull/5248#issuecomment-679011319
URL: https://github.com/SSSD/sssd/pull/5248 Title: #5248: Enable exclude functionality in sssd session recording configuration
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5248 Title: #5248: Enable exclude functionality in sssd session recording configuration
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5248 Title: #5248: Enable exclude functionality in sssd session recording configuration
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
justin-stephenson -
pbrezina