[PATCH] Fix a bad free in async_resolv.c

[Martin Nagy]

Simple one-liner.
Martin

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/06/2009 07:37 AM, Martin Nagy wrote:
>  Simple one-liner.
>  Martin
>  
>  
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel 
Ack.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkr0GT0ACgkQeiVVYja6o6OSpgCeJeNF67TgMHs5wJA57oZIeyac
> T6oAnjrQ/uffpgCi8GEzAeRKg4aIJFQV
> =NMAu
> -----END PGP SIGNATURE-----

[Simo Sorce]

On Fri, 2009-11-06 at 13:37 +0100, Martin Nagy wrote:
>  Simple one-liner. 
Nack, just remove the else free completely.
It will be freed anyway as soon as you return from the function in 99%
of the cases as the first thing after the _recv() is usually to free the
request.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Martin Nagy]

On Fri, 2009-11-06 at 08:12 -0500, Simo Sorce wrote:
>  On Fri, 2009-11-06 at 13:37 +0100, Martin Nagy wrote:
>  > Simple one-liner.
>  
>  Nack, just remove the else free completely.
>  It will be freed anyway as soon as you return from the function in 99%
>  of the cases as the first thing after the _recv() is usually to free the
>  request.
>  
>  Simo. 
As you wish. But in that case, I'll do the same for the two other
functions for consistency. New patch attached.

Martin

[Simo Sorce]

On Fri, 2009-11-06 at 17:51 +0100, Martin Nagy wrote:
>  On Fri, 2009-11-06 at 08:12 -0500, Simo Sorce wrote:
>  > On Fri, 2009-11-06 at 13:37 +0100, Martin Nagy wrote:
>  > > Simple one-liner.
>  > 
>  > Nack, just remove the else free completely.
>  > It will be freed anyway as soon as you return from the function in
>  99%
>  > of the cases as the first thing after the _recv() is usually to free
>  the
>  > request.
>  > 
>  > Simo.
>  
>  As you wish. But in that case, I'll do the same for the two other
>  functions for consistency. New patch attached. 
Ack.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Simo Sorce]

On Fri, 2009-11-06 at 12:07 -0500, Simo Sorce wrote:
>  On Fri, 2009-11-06 at 17:51 +0100, Martin Nagy wrote:
>  > On Fri, 2009-11-06 at 08:12 -0500, Simo Sorce wrote:
>  > > On Fri, 2009-11-06 at 13:37 +0100, Martin Nagy wrote:
>  > > > Simple one-liner.
>  > > 
>  > > Nack, just remove the else free completely.
>  > > It will be freed anyway as soon as you return from the function in
>  > 99%
>  > > of the cases as the first thing after the _recv() is usually to free
>  > the
>  > > request.
>  > > 
>  > > Simo.
>  > 
>  > As you wish. But in that case, I'll do the same for the two other
>  > functions for consistency. New patch attached.
>  
>  Ack. 
Pushed.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York