[PATCH] config_schema: Add ldap_user_email to schema

[Lukas Slebodnik]

ehlo,

yet another oneliner.
It reminds me that we should generate either schema or
data for python test.

LS

[Fabiano Fidêncio]

On Wed, Aug 10, 2016 at 8:23 AM, Lukas Slebodnik <lslebodn(a)redhat.com&gt; wrote:
>  ehlo,
>
>  yet another oneliner.
>  It reminds me that we should generate either schema or
>  data for python test. 
LGTM. Although, I'm not sure what you mean by generating either schema
or data for python tests.

>  LS
>
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/admin/lists/[e-mail]
>  


-- 
Fabiano Fidêncio

[Lukas Slebodnik]

On (10/08/16 09:13), Fabiano Fidêncio wrote:
> On Wed, Aug 10, 2016 at 8:23 AM, Lukas Slebodnik
> <lslebodn(a)redhat.com&gt; wrote:
> > ehlo,
> >
> > yet another oneliner.
> > It reminds me that we should generate either schema or
> > data for python test.
>
> LGTM. Although, I'm not sure what you mean by generating either schema
> or data for python tests.
>  
The commit [1] added new option ldap_user_email
It was added to
a) man page
b) C structures e.g. src/providers/*/*_opts.c
c) python bindings + data for python test/validation
   e.g. src/config/SSSDConfig, src/config/etc/
d) my patch added it into schema used by libini_config
   src/config/cfg_rules.ini

And it would be good to simplify/partially automate this process.

LS

[1]
https://git.fedorahosted.org/cgit/sssd.git/commit/?id=83a796ec8de4bde65b1...

[Lukas Slebodnik]

On (10/08/16 09:13), Fabiano Fidêncio wrote:
> On Wed, Aug 10, 2016 at 8:23 AM, Lukas Slebodnik
> <lslebodn(a)redhat.com&gt; wrote:
> > ehlo,
> >
> > yet another oneliner.
> > It reminds me that we should generate either schema or
> > data for python test.
>
> LGTM. Although, I'm not sure what you mean by generating either schema
> or data for python tests.
>  
master:
* a20968099c0e02f17311ab4b20680a872d464393

LS

[Jakub Hrozek]

On Wed, Aug 10, 2016 at 09:25:20AM +0200, Lukas Slebodnik wrote:
>  On (10/08/16 09:13), Fabiano Fidêncio wrote:
>  >On Wed, Aug 10, 2016 at 8:23 AM, Lukas Slebodnik <lslebodn(a)redhat.com&gt; wrote:
>  >> ehlo,
>  >>
>  >> yet another oneliner.
>  >> It reminds me that we should generate either schema or
>  >> data for python test.
>  >
>  >LGTM. Although, I'm not sure what you mean by generating either schema
>  >or data for python tests.
>  >
>  The commit [1] added new option ldap_user_email
>  It was added to
>  a) man page
>  b) C structures e.g. src/providers/*/*_opts.c
>  c) python bindings + data for python test/validation
>     e.g. src/config/SSSDConfig, src/config/etc/
>  d) my patch added it into schema used by libini_config
>     src/config/cfg_rules.ini
>  
>  And it would be good to simplify/partially automate this process. 
Yes, I even tried to pitch this as a small thesis topic for a university
project, but seems like nobody took the bait. Feel free to create a
ticket.

[Jakub Hrozek]

On Wed, Aug 10, 2016 at 09:35:26AM +0200, Jakub Hrozek wrote:
>  On Wed, Aug 10, 2016 at 09:25:20AM +0200, Lukas Slebodnik wrote:
>  > On (10/08/16 09:13), Fabiano Fidêncio wrote:
>  > >On Wed, Aug 10, 2016 at 8:23 AM, Lukas Slebodnik <lslebodn(a)redhat.com&gt;
> wrote:
>  > >> ehlo,
>  > >>
>  > >> yet another oneliner.
>  > >> It reminds me that we should generate either schema or
>  > >> data for python test.
>  > >
>  > >LGTM. Although, I'm not sure what you mean by generating either schema
>  > >or data for python tests.
>  > >
>  > The commit [1] added new option ldap_user_email
>  > It was added to
>  > a) man page
>  > b) C structures e.g. src/providers/*/*_opts.c
>  > c) python bindings + data for python test/validation
>  >    e.g. src/config/SSSDConfig, src/config/etc/
>  > d) my patch added it into schema used by libini_config
>  >    src/config/cfg_rules.ini
>  > 
>  > And it would be good to simplify/partially automate this process.
>  
>  Yes, I even tried to pitch this as a small thesis topic for a university
>  project, but seems like nobody took the bait. Feel free to create a
>  ticket. 
https://fedorahosted.org/sssd/ticket/3202