5:25 p.m.
URL: https://github.com/SSSD/sssd/pull/537
Author: fidencio
Title: #537: confdb_expand_application_domains() related issues (round 1)
Action: opened
PR body:
"""
The first patch fixes https://pagure.io/SSSD/sssd/issue/3660 by starting a ldb transaction
before modifying ldb to expand the application domains.
The second patch fixes https://pagure.io/SSSD/sssd/issue/3658 by also expanding app
domains when calling sssctl.
So, what's the best way to add test for those 2 patches?
Is it worth to add tests for the first patch? If yes, where? I couldn't find related
tests ...
About the second patch ... I didn't find any `sssctl domain-list` related test in our
repo ... is there a technical reason why `sssctl domain-list` tests were not written? is
it tested downstream only?
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/537/head:pr537
git checkout pr537
1:56 a.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
fidencio commented:
"""
CI: http://${abc)/logs/job/87/02/summary.html
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373279699
3:37 a.m.
New subject: [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Author: fidencio
Title: #537: confdb_expand_application_domains() related issues (round 1)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/537/head:pr537
git checkout pr537
10:31 a.m.
New subject: [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Author: fidencio
Title: #537: confdb_expand_application_domains() related issues (round 1)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/537/head:pr537
git checkout pr537
11:49 a.m.
New subject: [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Author: fidencio
Title: #537: confdb_expand_application_domains() related issues (round 1)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/537/head:pr537
git checkout pr537
11:50 a.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
fidencio commented:
"""
Answering my own question:
About the second patch ... I didn't find any sssctl domain-list
related test in our repo ... is there a technical reason why sssctl domain-list tests were
not written? is it tested downstream only?
It was not possible before due to the limitations on having the IFP responder running,
which was solved recently as part of https://pagure.io/SSSD/sssd/issue/2823.
Patch set has been updated with one test covering the application domain.
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373445792
12:12 p.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
fidencio commented:
"""
retest this please
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373453334
7:33 a.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
jhrozek commented:
"""
About the tests, I thought I submitted some, but looking at the tests, I guess it was only
in the PAM responder tests..
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373699808
7:33 a.m.
New subject: [sssd PR#537][+Changes requested] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
Label: +Changes requested
9:21 a.m.
New subject: [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Author: fidencio
Title: #537: confdb_expand_application_domains() related issues (round 1)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/537/head:pr537
git checkout pr537
9:23 a.m.
New subject: [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Author: fidencio
Title: #537: confdb_expand_application_domains() related issues (round 1)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/537/head:pr537
git checkout pr537
9:25 a.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
fidencio commented:
"""
@jhrozek, thanks for the review. I didn't know a ldb_transaction_start() would be a
no-op in case a transaction has already been started and that was the only reason I
didn't do the transaction related code inside sss_ldb_modify_permissive() in the first
place.
Patch set has been updated.
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373729309
9:26 a.m.
New subject: [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Author: fidencio
Title: #537: confdb_expand_application_domains() related issues (round 1)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/537/head:pr537
git checkout pr537
9:26 a.m.
New subject: [sssd PR#537][-Changes requested] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
Label: -Changes requested
10:01 a.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
fidencio commented:
"""
retest this please
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373740679
12:50 p.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
fidencio commented:
"""
=================================== FAILURES ===================================
______________________ test_sssctl_domain_list_app_domain ______________________
Traceback (most recent call last):
File
"/var/lib/jenkins/workspace/ci/label/rhel6/src/tests/intg/test_infopipe.py",
line 544, in test_sssctl_domain_list_app_domain
output = subprocess.check_output(cmd, stderr=subprocess.STDOUT)
AttributeError: 'module' object has no attribute 'check_output'
I'm adding back the "Changes Requested" label.
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373793531
12:50 p.m.
New subject: [sssd PR#537][+Changes requested] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
Label: +Changes requested
12:51 p.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
fidencio commented:
"""
The failure is el6 specific.
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373793680
12:52 p.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
jhrozek commented:
"""
One more minor update is needed, but we're getting there!
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373794127
1:29 p.m.
New subject: [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Author: fidencio
Title: #537: confdb_expand_application_domains() related issues (round 1)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/537/head:pr537
git checkout pr537
1:30 p.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
fidencio commented:
"""
Fixed your request and fixed the el6 related issue.
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373805080
1:30 p.m.
New subject: [sssd PR#537][-Changes requested] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
Label: -Changes requested
1:30 p.m.
New subject: [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Author: fidencio
Title: #537: confdb_expand_application_domains() related issues (round 1)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/537/head:pr537
git checkout pr537
3:47 p.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
fidencio commented:
"""
CI: http://vm-031.${abc}/logs/job/87/16/summary.html
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373840445
8:09 a.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
jhrozek commented:
"""
I'll just run Coverity again before pushing.
btw I noticed during review of the KCM limits PR that the two seem to be conflicting atop
one another, so some rebasing might be due, but let's do that once we push one or the
other.
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-374205769
6:05 a.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
jhrozek commented:
"""
Coverity was cleaned, I just forgot to add the Accepted label.
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-376128751
6:05 a.m.
New subject: [sssd PR#537][+Accepted] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
Label: +Accepted
2:01 p.m.
New subject: [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Title: #537: confdb_expand_application_domains() related issues (round 1)
jhrozek commented:
"""
14b485b11c31341c6874ac4183f757287fb30f64
885da2c88a214eddd8c5ba16118debdf7e8f2666
a73d70f7ebe194337d7732fd644384c94c2ce0d5
f405a4a3694957b5a5cb45d0f7ea2854d876cbb6
e5c74ab068d87b598d1090c83f1c4d9e47939c83
"""
See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-376275621
2:01 p.m.
New subject: [sssd PR#537][closed] confdb_expand_application_domains() related issues (round 1)
URL: https://github.com/SSSD/sssd/pull/537
Author: fidencio
Title: #537: confdb_expand_application_domains() related issues (round 1)
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/537/head:pr537
git checkout pr537
2233
days inactive
2245
days old
sssd-devel@lists.fedorahosted.org
28 comments
2 participants
participants (2)
-
fidencio -
jhrozek