7:28 a.m.
URL: https://github.com/SSSD/sssd/pull/5509
Author: alexey-tikhonov
Title: #5509: spec file: don't enable implicit files domain on RHEL
Action: opened
PR body:
"""
Corresponding code is built and users can enable files domain
on a as-needed basis. But there is little value running it on
RHEL "as is" by default.
(As a reminder, as a comment in this file says, this is a
"SSSD SPEC file for Fedora 34+ and RHEL-9+")
Originally it was opened as https://src.fedoraproject.org/rpms/sssd/pull-request/8 but
@pbrezina asked to move it upstream.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5509/head:pr5509
git checkout pr5509
7:32 a.m.
New subject: [sssd PR#5509][+Waiting for review] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
Label: +Waiting for review
9:37 a.m.
New subject: [sssd PR#5509][comment] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
thalman commented:
"""
Looks good to me, Thanks
"""
See the full comment at https://github.com/SSSD/sssd/pull/5509#issuecomment-780641217
3:37 a.m.
New subject: [sssd PR#5509][comment] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
pbrezina commented:
"""
Can you move it to `--disable-polkit-rules-path` line to avoid having multiple conditions
there?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5509#issuecomment-781214051
5:35 a.m.
New subject: [sssd PR#5509][synchronized] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Author: alexey-tikhonov
Title: #5509: spec file: don't enable implicit files domain on RHEL
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5509/head:pr5509
git checkout pr5509
5:36 a.m.
New subject: [sssd PR#5509][comment] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
alexey-tikhonov commented:
"""
Updated.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5509#issuecomment-781281987
5:58 a.m.
New subject: [sssd PR#5509][comment] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
pbrezina commented:
"""
Why not keep fedora specific flags at the end? IMHO it's more readable then
interrupting it with condition in the middle.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5509#issuecomment-781293131
6:03 a.m.
New subject: [sssd PR#5509][comment] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
alexey-tikhonov commented:
"""
Why not keep fedora specific flags at the end? IMHO it's more
readable then interrupting it with condition in the middle.
My idea was to keep it sorted like: "enable/disable" first and then a bunch of
"--with-..."
But ok, I will move.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5509#issuecomment-781295725
6:04 a.m.
New subject: [sssd PR#5509][synchronized] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Author: alexey-tikhonov
Title: #5509: spec file: don't enable implicit files domain on RHEL
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5509/head:pr5509
git checkout pr5509
6:32 a.m.
New subject: [sssd PR#5509][comment] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
pbrezina commented:
"""
> Why not keep fedora specific flags at the end? IMHO it's
more readable then interrupting it with condition in the middle.
My idea was to keep it sorted like: "enable/disable" first and then a bunch of
"--with-..."
But ok, I will move.
If that's the case, we can use oneliners like `%{?with_static:--enable-static}` and
sort it appropriately. But I'm fine with this version.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5509#issuecomment-781311300
7:16 a.m.
New subject: [sssd PR#5509][comment] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
thalman commented:
"""
I'm fine with this new version, Thanks
"""
See the full comment at https://github.com/SSSD/sssd/pull/5509#issuecomment-781336517
7:17 a.m.
New subject: [sssd PR#5509][+Ready to push] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
Label: +Ready to push
7:17 a.m.
New subject: [sssd PR#5509][-Waiting for review] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
Label: -Waiting for review
7:17 a.m.
New subject: [sssd PR#5509][+Accepted] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
Label: +Accepted
3:11 a.m.
New subject: [sssd PR#5509][comment] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5509
* `master`
* a53c214b77a305f9a0a1d038254567c7e7c07a53 - spec file: don't enable implicit
files domain on RHEL
"""
See the full comment at https://github.com/SSSD/sssd/pull/5509#issuecomment-781942498
3:11 a.m.
New subject: [sssd PR#5509][+Pushed] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
Label: +Pushed
3:11 a.m.
New subject: [sssd PR#5509][-Accepted] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
Label: -Accepted
3:11 a.m.
New subject: [sssd PR#5509][-Ready to push] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Title: #5509: spec file: don't enable implicit files domain on RHEL
Label: -Ready to push
3:11 a.m.
New subject: [sssd PR#5509][closed] spec file: don't enable implicit files domain on RHEL
URL: https://github.com/SSSD/sssd/pull/5509
Author: alexey-tikhonov
Title: #5509: spec file: don't enable implicit files domain on RHEL
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5509/head:pr5509
git checkout pr5509
1170
days inactive
1172
days old
sssd-devel@lists.fedorahosted.org
18 comments
3 participants
participants (3)
-
alexey-tikhonov -
pbrezina
-
thalman