[sssd PR#12] failover: proceed normally when no new server is found (opened)

[fidencio]

pbrezina's pull request #12: "failover: proceed normally when no new server is found" was opened

PR body:
"""
https://fedorahosted.org/sssd/ticket/3131

I couldn't reproduce manually so I used the second patch as a by-code reproducer. If you apply the patch then sssd will try to resolve meta server twice simultaneously and triggering the problematic code path. You can search for RESOLV SRV DONE in logs.
"""

See the full pull-request at https://github.com/SSSD/sssd/pull/12
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/12/head:pr12
git checkout pr12

[sssd PR#12] failover: proceed normally when no new server is found (comment)

[fidencio]

fidencio commented on a pull request

"""
Patch looks good to me and the reporter already said it fixed the problem for him.
Is it possible to easily have tests for this part of the code? If yes, tests would be welcome.

I'd say it's an ACK for me as long as it passes CI, but I'd be a bit more comfortable if someone else more experienced in the project could also take a look.
"""

See the full comment at https://github.com/SSSD/sssd/pull/12#issuecomment-245829680

[sssd PR#12][comment] failover: proceed normally when no new server is found

[fidencio]

URL: https://github.com/SSSD/sssd/pull/12
Title: #12: failover: proceed normally when no new server is found

jhrozek commented:
"""
ACK. I wrote a simple test and will submit a PR separately.
"""

See the full comment at https://github.com/SSSD/sssd/pull/12#issuecomment-248552171

[sssd PR#12][+Accepted] failover: proceed normally when no new server is found

[fidencio]

URL: https://github.com/SSSD/sssd/pull/12
Title: #12: failover: proceed normally when no new server is found

Label: +Accepted

[sssd PR#12][comment] failover: proceed normally when no new server is found

[fidencio]

URL: https://github.com/SSSD/sssd/pull/12
Title: #12: failover: proceed normally when no new server is found

jhrozek commented:
"""
@pbrezina I will push this one if you ack https://github.com/SSSD/sssd/pull/29 so that we also have tests..
"""

See the full comment at https://github.com/SSSD/sssd/pull/12#issuecomment-248552866

[sssd PR#12][comment] failover: proceed normally when no new server is found

[fidencio]

URL: https://github.com/SSSD/sssd/pull/12
Title: #12: failover: proceed normally when no new server is found

jhrozek commented:
"""
* master: 03cb5ac6aa4c60d2c64c6fdc2daae656bf5493f4
"""

See the full comment at https://github.com/SSSD/sssd/pull/12#issuecomment-248831706

[sssd PR#12][-Accepted] failover: proceed normally when no new server is found

[fidencio]

URL: https://github.com/SSSD/sssd/pull/12
Title: #12: failover: proceed normally when no new server is found

Label: -Accepted

[sssd PR#12][+Pushed] failover: proceed normally when no new server is found

[fidencio]

URL: https://github.com/SSSD/sssd/pull/12
Title: #12: failover: proceed normally when no new server is found

Label: +Pushed

[sssd PR#12][closed] failover: proceed normally when no new server is found

[fidencio]

URL: https://github.com/SSSD/sssd/pull/12
Author: pbrezina
 Title: #12: failover: proceed normally when no new server is found
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/12/head:pr12
git checkout pr12