[sssd PR#916][opened] Fix one coverity issue

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/916
Author: alexey-tikhonov
 Title: #916: Fix one coverity issue
Action: opened

PR body:
"""
...and reduce code duplication a little bit.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/916/head:pr916
git checkout pr916

[sssd PR#916][+Waiting for review] Fix one coverity issue

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

Label: +Waiting for review

[sssd PR#916][comment] Fix one coverity issue

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

mzidek-rh commented:
"""
I talked to Alexey offline, there are few issues. So adding changes requested.

JFTR:
- a socket file descriptor was replaced by 0 (stdin) by a mistake
- I think the 3rd patch could be left out (I like the goto version more for the added "boiler plate" against future mistakes in case we add more code to the function, but that will probably not happen, so I will let Alexey to decide, I am fine either way)
"""

See the full comment at https://github.com/SSSD/sssd/pull/916#issuecomment-549428566

[sssd PR#916][+Changes requested] Fix one coverity issue

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

Label: +Changes requested

[sssd PR#916][-Waiting for review] Fix one coverity issue

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

Label: -Waiting for review

[sssd PR#916][comment] Fix one coverity issue

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

alexey-tikhonov commented:
"""
> * a socket file descriptor was replaced by 0 (stdin) by a mistake

Thank you, good catch! Fixed.
> * I think the 3rd patch could be left out (I like the goto version more for the added "boiler plate" against future mistakes in case we add more code to the function, but that will probably not happen, so I will let Alexey to decide, I am fine either way)

But this is the main purpose of this PR (to reduce covscan complains). So I am looking for a way to please Coverity while keeping "done" section there...

"""

See the full comment at https://github.com/SSSD/sssd/pull/916#issuecomment-549833970

[sssd PR#916][comment] Fix one coverity issue

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

alexey-tikhonov commented:
"""
> a socket file descriptor was replaced by 0 (stdin) by a mistake

Thank you, good catch! Fixed.
> I think the 3rd patch could be left out (I like the goto version more for the added "boiler plate" against future mistakes in case we add more code to the function, but that will probably not happen, so I will let Alexey to decide, I am fine either way)

But this is the main purpose of this PR (to reduce covscan complains). So I am looking for a way to please Coverity while keeping "done" section there...

"""

See the full comment at https://github.com/SSSD/sssd/pull/916#issuecomment-549833970

[sssd PR#916][synchronized] Fix one coverity issue

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/916
Author: alexey-tikhonov
 Title: #916: Fix one coverity issue
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/916/head:pr916
git checkout pr916

[sssd PR#916][comment] Fix one coverity issue

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

alexey-tikhonov commented:
"""
Hi @mzidek-rh,

I have fixed found issue and rewrote third patch to keep done section (still fixing Coverity issue).

Please, take a look.
"""

See the full comment at https://github.com/SSSD/sssd/pull/916#issuecomment-549871081

[sssd PR#916][-Changes requested] Fix one coverity issue

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

Label: -Changes requested

[sssd PR#916][+Waiting for review] Fix one coverity issue

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

Label: +Waiting for review

[sssd PR#916][comment] Fix one coverity issue

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

mzidek-rh commented:
"""
Thanks. ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/916#issuecomment-550255907

[sssd PR#916][-Waiting for review] Fix one coverity issue

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

Label: -Waiting for review

[sssd PR#916][+Accepted] Fix one coverity issue

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

Label: +Accepted

[sssd PR#916][+Ready to push] Fix one coverity issue

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

Label: +Ready to push

[sssd PR#916][comment] Fix one coverity issue

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

pbrezina commented:
"""
* `master`
    * 3c09e9dceec016c4f31452506d5ddb012f8a82d7 - sss_ssh_knownhostsproxy: fixed Coverity issue
    * 0102a253eeafee0365f3336ad6bd94606eaf484d - sss_ssh_knownhostsproxy: relocated O_NONBLOCK setting
    * 24d9d213c0767e1eff5dfbd212d567b2ce1e26d5 - Reduces code duplication

"""

See the full comment at https://github.com/SSSD/sssd/pull/916#issuecomment-551056423

[sssd PR#916][+Pushed] Fix one coverity issue

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

Label: +Pushed

[sssd PR#916][-Accepted] Fix one coverity issue

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

Label: -Accepted

[sssd PR#916][-Ready to push] Fix one coverity issue

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/916
Title: #916: Fix one coverity issue

Label: -Ready to push

[sssd PR#916][closed] Fix one coverity issue

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/916
Author: alexey-tikhonov
 Title: #916: Fix one coverity issue
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/916/head:pr916
git checkout pr916