Jakub Hrozek <jhrozek(a)redhat.com> wrote:
[PATCH 1/3] The systemd unit file should not require DBus
This patch fixes the provided systemd unit file so it is the same
as the one Jóhann B. Guðmundsson provided in Red Hat Bugzilla #689853
except for hardcoded paths.
ack
[PATCH 2/3] Provide a configuration option to use systemd unit file
https://fedorahosted.org/sssd/ticket/837
Stephen, I'll leave this one to you, since looking at the code related to
autotools makes my eyes bleed.
[PATCH 3/3] NOSUBMIT: systemd support in sssd rpm
I don't think we should push this patch, but I think it would ease
review. After applying this patch, sysv is still the default. To build
sssd packages with systemd unit file, change the bcond_with to
bcond_without (yes, bcond_without systemd means build with systemd as it
makes rpmbuild accept a --without-systemd option):
-%bcond_with systemd
+%bcond_without systemd
In case we want to push this patch upstream (maybe in the future), I have
couple notes:
When we build with systemd, I think dependencies on init scripts should be
removed.
Option --with-init-dir should not be deleted but rather conditionally used.
In the last hunk, systemctl disable and stop is used. Apparently this order
won't cause any troubles but I still think it should be reversed (stop first
and disable second).
--
Thank you
Jan Zeleny
Red Hat Software Engineer
Brno, Czech Republic