[sssd PR#755][opened] ad: replace ARRAY_SIZE with N_ELEMENTS

[sumit-bose]

   URL: https://github.com/SSSD/sssd/pull/755
Author: sumit-bose
 Title: #755: ad: replace ARRAY_SIZE with N_ELEMENTS
Action: opened

PR body:
"""
ARRAY_SIZE is taken from the Samba header file memory.h which is not
available as a public header in newer Samba versions anymore. This patch
replaces it with an internal macro.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/755/head:pr755
git checkout pr755

[sssd PR#755][comment] ad: replace ARRAY_SIZE with N_ELEMENTS

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/755
Title: #755: ad: replace ARRAY_SIZE with N_ELEMENTS

jhrozek commented:
"""
The Jenkins pipeline on F-29 failed with "java.io.FileNotFoundException:
/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.191.b12-11.fc28.x86_64/jre/lib/tzdb.dat (No such
file or directory)" @pbrezina could you please take a look?
"""

See the full comment at https://github.com/SSSD/sssd/pull/755#issuecomment-464022598

[sssd PR#755][comment] ad: replace ARRAY_SIZE with N_ELEMENTS

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/755
Title: #755: ad: replace ARRAY_SIZE with N_ELEMENTS

jhrozek commented:
"""
That's of course unrelated to the patch, so I'll just run it through the internal
CI for process' sake before pushing.
"""

See the full comment at https://github.com/SSSD/sssd/pull/755#issuecomment-464022834

[sssd PR#755][+Accepted] ad: replace ARRAY_SIZE with N_ELEMENTS

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/755
Title: #755: ad: replace ARRAY_SIZE with N_ELEMENTS

Label: +Accepted

[sssd PR#755][comment] ad: replace ARRAY_SIZE with N_ELEMENTS

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/755
Title: #755: ad: replace ARRAY_SIZE with N_ELEMENTS

jhrozek commented:
"""
ACK, CI http://$ABC/logs/job/96/85/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/755#issuecomment-464065689

[sssd PR#755][comment] ad: replace ARRAY_SIZE with N_ELEMENTS

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/755
Title: #755: ad: replace ARRAY_SIZE with N_ELEMENTS

pbrezina commented:
"""
I re-ran ci tests.
"""

See the full comment at https://github.com/SSSD/sssd/pull/755#issuecomment-464101329

[sssd PR#755][closed] ad: replace ARRAY_SIZE with N_ELEMENTS

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/755
Author: sumit-bose
 Title: #755: ad: replace ARRAY_SIZE with N_ELEMENTS
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/755/head:pr755
git checkout pr755

[sssd PR#755][comment] ad: replace ARRAY_SIZE with N_ELEMENTS

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/755
Title: #755: ad: replace ARRAY_SIZE with N_ELEMENTS

jhrozek commented:
"""
Thanks @pbrezina the error looked like something wrong with the install to me, that's
why I asked you to look.

Pushed to master:
 * e1ff063ffa4ad459bd0c8a9da56abf8379401dbe
 * e32920a9c7998476b596507762b28fcf81f6a456
and sssd-1-16:
 * 911d7bb589c29c10c581d682e691364a88d35602
 * 0a27fba0a34a6bc1cc23607dd4dc14cdc6803eb
"""

See the full comment at https://github.com/SSSD/sssd/pull/755#issuecomment-464391158

[sssd PR#755][+Pushed] ad: replace ARRAY_SIZE with N_ELEMENTS

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/755
Title: #755: ad: replace ARRAY_SIZE with N_ELEMENTS

Label: +Pushed