[sssd PR#5685][opened] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Author: justin-stephenson
 Title: #5685: KCM: Add krb5-libs dependency in spec
Action: opened

PR body:
"""

"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5685/head:pr5685
git checkout pr5685

[sssd PR#5685][+Waiting for review] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: +Waiting for review

[sssd PR#5685][+Bugzilla] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: +Bugzilla

[sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

justin-stephenson commented:
"""
https://bugzilla.redhat.com/show_bug.cgi?id=1716981
"""

See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-861422130

[sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

[rwmjones]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

rwmjones commented:
"""
I don't believe this change is correct.  `krb5-libs` was installed, it was just a too-old version, so this change wouldn't make any difference.  In fact RPM automatic dependencies already pick up the need for the library:

```
$ rpm -qR sssd-kcm | grep krb5
libkrb5.so.3()(64bit)
libkrb5.so.3(krb5_3_MIT)(64bit)
```

The real problem is in krb5-libs itself, where symbols aren't properly versioned.  Every time you add a new symbol (or more realisticly, when you do an upstream release containing new symbols) you should add a new version section to your linker script.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-861434301

[sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

[rwmjones]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

rwmjones commented:
"""
Here's an example of how to do it from libvirt:

https://gitlab.com/libvirt/libvirt/-/blob/master/src/libvirt_public.syms
"""

See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-861434788

[sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

[rwmjones]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

rwmjones commented:
"""
I should add the reason why this will work is because the versioned symbols will be added to the RPM dependencies.  eg. libvirt "provides":
```
$ rpm -q --provides libvirt-libs
libvirt.so.0()(64bit)
libvirt.so.0(LIBVIRT_0.0.3)(64bit)
libvirt.so.0(LIBVIRT_0.0.5)(64bit)
libvirt.so.0(LIBVIRT_0.1.0)(64bit)
libvirt.so.0(LIBVIRT_0.1.1)(64bit)
libvirt.so.0(LIBVIRT_0.1.4)(64bit)
...
libvirt.so.0(LIBVIRT_7.2.0)(64bit)
libvirt.so.0(LIBVIRT_7.3.0)(64bit)
```
and programs that use libvirt require only the particular symbol versions they actually use:
```
$ rpm -qR virt-top
libvirt.so.0()(64bit)
libvirt.so.0(LIBVIRT_0.0.3)(64bit)
libvirt.so.0(LIBVIRT_0.0.5)(64bit)
libvirt.so.0(LIBVIRT_0.1.0)(64bit)
libvirt.so.0(LIBVIRT_0.1.1)(64bit)
libvirt.so.0(LIBVIRT_0.1.4)(64bit)
libvirt.so.0(LIBVIRT_0.1.5)(64bit)
libvirt.so.0(LIBVIRT_0.1.9)(64bit)
libvirt.so.0(LIBVIRT_0.2.0)(64bit)
libvirt.so.0(LIBVIRT_0.2.1)(64bit)
...
libvirt.so.0(LIBVIRT_1.2.8)(64bit)
```

This is all done automatically by RPM.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-861447236

[sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

pbrezina commented:
"""
Justing, I believe what we need is to require krb5-libs >= the version that contains required API.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-863164713

[sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

pbrezina commented:
"""
Justin, I believe what we need is to require krb5-libs >= the version that contains required API.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-863164713

[sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

[rwmjones]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

rwmjones commented:
"""
> Justin, I believe what we need is to require krb5-libs >= the version that contains required API.

Yes I agree.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-863257621

[sssd PR#5685][synchronized] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Author: justin-stephenson
 Title: #5685: KCM: Add krb5-libs dependency in spec
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5685/head:pr5685
git checkout pr5685

[sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

pbrezina commented:
"""
This fails CI for RHEL8 and Fedora 33. We still need to support those. Please exlucde the line for older versions (< F34, < RHEL8.5). It also should be a BuildRequire on those systems and I think we also want to explicitly enable it through --enable-renewals.

Define the support through variable and then rely on this variable, e.g.:
```
%if cond
%global build_kcm_renewals 1
%endif
```
"""

See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-863939033

[sssd PR#5685][+Changes requested] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: +Changes requested

[sssd PR#5685][-Waiting for review] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: -Waiting for review

[sssd PR#5685][synchronized] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Author: justin-stephenson
 Title: #5685: KCM: Add krb5-libs dependency in spec
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5685/head:pr5685
git checkout pr5685

[sssd PR#5685][synchronized] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Author: justin-stephenson
 Title: #5685: KCM: Add krb5-libs dependency in spec
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5685/head:pr5685
git checkout pr5685

[sssd PR#5685][synchronized] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Author: justin-stephenson
 Title: #5685: KCM: Add krb5-libs dependency in spec
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5685/head:pr5685
git checkout pr5685

[sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

pbrezina commented:
"""
Isn't BuildRequires useless at this place?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-878991651

[sssd PR#5685][synchronized] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Author: justin-stephenson
 Title: #5685: KCM: Add krb5-libs dependency in spec
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5685/head:pr5685
git checkout pr5685

[sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

justin-stephenson commented:
"""
> Isn't BuildRequires useless at this place?

Fixed. 
"""

See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-879267562

[sssd PR#5685][-Changes requested] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: -Changes requested

[sssd PR#5685][+Waiting for review] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: +Waiting for review

[sssd PR#5685][synchronized] KCM: Add krb5-libs dependency in spec

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5685
Author: justin-stephenson
 Title: #5685: KCM: Add krb5-libs dependency in spec
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5685/head:pr5685
git checkout pr5685

[sssd PR#5685][+Ready to push] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: +Ready to push

[sssd PR#5685][-Waiting for review] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: -Waiting for review

[sssd PR#5685][+Accepted] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: +Accepted

[sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5685

* `master`
    * 4b7b6fa70399654b8a6d2f691be832c0680ee1fb - KCM: Add krb5-libs dependency in spec

"""

See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-915035623

[sssd PR#5685][+Pushed] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: +Pushed

[sssd PR#5685][-Accepted] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: -Accepted

[sssd PR#5685][-Ready to push] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Title: #5685: KCM: Add krb5-libs dependency in spec

Label: -Ready to push

[sssd PR#5685][closed] KCM: Add krb5-libs dependency in spec

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5685
Author: justin-stephenson
 Title: #5685: KCM: Add krb5-libs dependency in spec
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5685/head:pr5685
git checkout pr5685