[sssd PR#500][opened] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/500
Author: jhrozek
 Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading
subdomain UPNs
Action: opened

PR body:
"""
Related to: https://pagure.io/SSSD/sssd/issue/3431

There was a typo in code that read the UPN suffixes from the subdomain
ldb_message. As a result, the UPN suffixes from the first domain were
always consulted for all domains.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/500/head:pr500
git checkout pr500

[sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading
subdomain UPNs

lslebodn commented:
"""
That's a really nice catch.

LGTM We might file a ticket to extract 167 lines from for loop to separate function to
prevent such issues. (if possible)

The but is there since 1.14.1 and I would prefer if @sumit-bose could double check 
"""

See the full comment at https://github.com/SSSD/sssd/pull/500#issuecomment-359795924

[sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading
subdomain UPNs

sumit-bose commented:
"""
Yes, this is a typo which should be fixed.
"""

See the full comment at https://github.com/SSSD/sssd/pull/500#issuecomment-359815902

[sssd PR#500][+Accepted] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading
subdomain UPNs

Label: +Accepted

[sssd PR#500][closed] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/500
Author: jhrozek
 Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading
subdomain UPNs
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/500/head:pr500
git checkout pr500

[sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading
subdomain UPNs

lslebodn commented:
"""
master:
* a8a3fcbf6f75a7c2665e8bf503c186e07dfab333

sssd-1-14:
* 76957f07f79fb30634d2b5b4bed56cf30307c079
"""

See the full comment at https://github.com/SSSD/sssd/pull/500#issuecomment-359866512

[sssd PR#500][+Pushed] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading
subdomain UPNs

Label: +Pushed

[sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading
subdomain UPNs

lslebodn commented:
"""
The patch does not apply to 1.13 branch (probably due to missing other patch :-)
IIRC we have some ticket which should fix UPN related bugs in 1.13.
So we should not forget to backport it.
"""

See the full comment at https://github.com/SSSD/sssd/pull/500#issuecomment-359867017

[sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading
subdomain UPNs

jhrozek commented:
"""
Yes, I'm still working on the downstream report for sssd-1-13. Sadly, even my latest
backport didn't help, so I'll check if maybe this problem was the issue..
"""

See the full comment at https://github.com/SSSD/sssd/pull/500#issuecomment-359894434