URL: https://github.com/SSSD/sssd/pull/79 Author: fidencio Title: #79: LIBSSS_CONFIG: Drop libsss_config Action: opened
PR body: """ libssss_config has been used only by OpenLMI and the project has been deprecated making, then, no sense to keep the support on SSSD.
Distros that, for some reason, are still packing and distributing OpenLMI can stick to SSSD 1.14 branch.
Signed-off-by: Fabiano Fidêncio fidencio@redhat.com """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/79/head:pr79 git checkout pr79
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: LIBSSS_CONFIG: Drop libsss_config
fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/56/93/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/79#issuecomment-259803386
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: LIBSSS_CONFIG: Drop libsss_config
lslebodn commented: """ You forgot to rebuve build dependencies from spec file and from ci.deps
contrib/ci/deps.sh: libaugeas-dev contrib/sssd.spec.in:BuildRequires: augeas-devel
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/79#issuecomment-259916977
URL: https://github.com/SSSD/sssd/pull/79 Author: fidencio Title: #79: LIBSSS_CONFIG: Drop libsss_config Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/79/head:pr79 git checkout pr79
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: LIBSSS_CONFIG: Drop libsss_config
fidencio commented: """ Change done. Here is the fix up patch that in order to help the reviewer: ``` [ffidenci@cat sssd]$ git diff HEAD diff --git a/contrib/ci/deps.sh b/contrib/ci/deps.sh index 9a7098c..387ad1f 100644 --- a/contrib/ci/deps.sh +++ b/contrib/ci/deps.sh @@ -69,7 +69,6 @@ if [[ "$DISTRO_BRANCH" == -debian-* ]]; then docbook-xsl gettext krb5-config - libaugeas-dev libc-ares-dev libcmocka-dev libcollection-dev diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in index 2917629..f0b61ec 100644 --- a/contrib/sssd.spec.in +++ b/contrib/sssd.spec.in @@ -583,7 +583,6 @@ be used by Python applications. Summary: The D-Bus responder of the SSSD Group: Applications/System License: GPLv3+ -BuildRequires: augeas-devel Requires: sssd-common = %{version}-%{release}
%description dbus ``` """
See the full comment at https://github.com/SSSD/sssd/pull/79#issuecomment-259934118
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: LIBSSS_CONFIG: Drop libsss_config
lslebodn commented: """ There is a tiny conflict due to change in `src/external/configlib.m4`
There is also typo in commit message `libssss_config` and IMHO it might be better to use "BUILD" as a component in commit title rather then `LIBSSS_CONFIG`.
I think you also forgot to remove methods from `src/responder/ifp/ifp_iface.xml` which is used for generating C code. """
See the full comment at https://github.com/SSSD/sssd/pull/79#issuecomment-262518170
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: LIBSSS_CONFIG: Drop libsss_config
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/79 Author: fidencio Title: #79: LIBSSS_CONFIG: Drop libsss_config Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/79/head:pr79 git checkout pr79
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: LIBSSS_CONFIG: Drop libsss_config
fidencio commented: """ Suggestion taken and changes done, thanks for the review! I've just pushed a new version of the patch. """
See the full comment at https://github.com/SSSD/sssd/pull/79#issuecomment-262529623
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: LIBSSS_CONFIG: Drop libsss_config
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/79 Author: fidencio Title: #79: BUILD: Drop libsss_config Action: edited
Changed field: title Original value: """ LIBSSS_CONFIG: Drop libsss_config """
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: BUILD: Drop libsss_config
lslebodn commented: """ You probably missed one comment. Is there a reason why `ifp_component_change_debug_level_tmp` was not removed?
Otherwise LGTM """
See the full comment at https://github.com/SSSD/sssd/pull/79#issuecomment-262765095
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: BUILD: Drop libsss_config
lslebodn commented: """ Ahh, I've just noticed that this function does not depend on auges/libsss_config. It just changes values in confdb. Which is temporary just by a chance and it would work only after restarting services. Do we need to keep it?
@pbrezina What do you think about remoing `ChangeDebugLevelTemporarily`? """
See the full comment at https://github.com/SSSD/sssd/pull/79#issuecomment-262768026
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: BUILD: Drop libsss_config
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: BUILD: Drop libsss_config
lslebodn commented: """ `ChangeDebugLevelTemporarily` does not depend on auges so it can be removed later. master: * 99b2352f909c548811617389641a9ccc3e17bc53 """
See the full comment at https://github.com/SSSD/sssd/pull/79#issuecomment-262808633
URL: https://github.com/SSSD/sssd/pull/79 Author: fidencio Title: #79: BUILD: Drop libsss_config Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/79/head:pr79 git checkout pr79
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: BUILD: Drop libsss_config
lslebodn commented: """ Just let you know the openlmi is orphaned and was removed from fedora """
See the full comment at https://github.com/SSSD/sssd/pull/79#issuecomment-263869554
sssd-devel@lists.fedorahosted.org
-
fidencio