On (18/07/16 07:48), Petr Cech wrote:
Hi list,
I was debug code very deeply and I found nitpick.
There is simple patch attached.
Regards
--
Petr^4 Čech
From 15d35c7e0e2171c49746d3a87f9aa2aba07a7bbc Mon Sep 17 00:00:00
2001
From: Petr Cech <pcech(a)redhat.com>
Date: Sun, 17 Jul 2016 11:36:18 +0200
Subject: [PATCH] PROVIDERS: Default values in debug
It could be usefull to distinguish between deafult and config values
in debug messages.
---
src/providers/data_provider_opts.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/src/providers/data_provider_opts.c b/src/providers/data_provider_opts.c
index 9db43fc4077d3b14f2358029c7d532e440930879..d375c779a75ac1103efd8766026ed6604c1ca0f9
100644
--- a/src/providers/data_provider_opts.c
+++ b/src/providers/data_provider_opts.c
@@ -219,9 +219,10 @@ static int dp_copy_options_ex(TALLOC_CTX *memctx,
opts[i].opt_name);
goto done;
}
- DEBUG(SSSDBG_TRACE_FUNC, "Option %s has%s value %s\n",
+ DEBUG(SSSDBG_TRACE_FUNC, "Option %s has%s %svalue %s\n",
opts[i].opt_name,
opts[i].val.cstring ? "" : " no",
+ copy_values ? "" : "default ",
What is a
benefit of string "default ".
How does it improve reading debug messages with very high debug level?
Why should we care wheter it's default or not?
LS