11:16 a.m.
URL: https://github.com/SSSD/sssd/pull/5803
Author: alexey-tikhonov
Title: #5803: CONF: removed unused 'sbus_timeout' option
Action: opened
PR body:
"""
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=2001791
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5803/head:pr5803
git checkout pr5803
11:16 a.m.
New subject: [sssd PR#5803][+Waiting for review] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
Label: +Waiting for review
11:16 a.m.
New subject: [sssd PR#5803][+Bugzilla] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
Label: +Bugzilla
8:31 a.m.
New subject: [sssd PR#5803][comment] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
ikerexxe commented:
"""
The changes look good to me but I think that you should link an upstream ticket both in
the commit message and in the PR description.
Moreover, I wonder if we should notify in the next release that the option is no longer
available.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5803#issuecomment-936240331
8:31 a.m.
New subject: [sssd PR#5803][-Waiting for review] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
Label: -Waiting for review
8:31 a.m.
New subject: [sssd PR#5803][+Changes requested] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
Label: +Changes requested
8:51 a.m.
New subject: [sssd PR#5803][comment] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
alexey-tikhonov commented:
"""
The changes look good to me but I think that you should link an
upstream ticket both in the commit message and in the PR description.
Moreover, I wonder if we should notify in the next release that the option is no longer
available.
But the options was NOT available. I mean, putting this option in sssd.conf did NOT have
any effect.
This is merely removal of code that did nothing, so I don't think it's worth a
ticket and especially a RN.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5803#issuecomment-936275819
9:12 a.m.
New subject: [sssd PR#5803][comment] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
ikerexxe commented:
"""
But the options was NOT available. I mean, putting this option in
sssd.conf did NOT have any effect. This is merely removal of code that did nothing, so I
don't think it's worth a ticket and especially a RN.
In that case, everything looks good to me. Thanks for the patch!
"""
See the full comment at https://github.com/SSSD/sssd/pull/5803#issuecomment-936312056
9:12 a.m.
New subject: [sssd PR#5803][-Changes requested] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
Label: -Changes requested
9:12 a.m.
New subject: [sssd PR#5803][+Accepted] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
Label: +Accepted
5:37 a.m.
New subject: [sssd PR#5803][+Ready to push] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
Label: +Ready to push
5:40 a.m.
New subject: [sssd PR#5803][comment] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5803
* `master`
* c4c0fd690d82f9a8a714784ad4e036a39e1017fc - CONF: removed unused
'sbus_timeout' option
"""
See the full comment at https://github.com/SSSD/sssd/pull/5803#issuecomment-937670822
5:40 a.m.
New subject: [sssd PR#5803][+Pushed] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
Label: +Pushed
5:40 a.m.
New subject: [sssd PR#5803][-Accepted] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
Label: -Accepted
5:40 a.m.
New subject: [sssd PR#5803][-Ready to push] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option
Label: -Ready to push
5:40 a.m.
New subject: [sssd PR#5803][closed] CONF: removed unused 'sbus_timeout' option
URL: https://github.com/SSSD/sssd/pull/5803
Author: alexey-tikhonov
Title: #5803: CONF: removed unused 'sbus_timeout' option
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5803/head:pr5803
git checkout pr5803
976
days inactive
982
days old
sssd-devel@lists.fedorahosted.org
15 comments
3 participants
participants (3)
-
alexey-tikhonov -
ikerexxe
-
pbrezina