[PATCH] Fix broken LOCAL password changes

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

We forgot the LOCAL provider when we added support for PAM_PRELIM_CHECK.


- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAksr46gACgkQeiVVYja6o6PX1gCeLNzoHfquR9liqCWjnSoLJojk
> 0RYAn32hChusOlfTkp0QJCPJQd6VPfeN
> =+7Qk
> -----END PGP SIGNATURE-----

[Simo Sorce]

On Fri, 18 Dec 2009 15:18:48 -0500
Stephen Gallagher <sgallagh(a)redhat.com&gt; wrote:

>  We forgot the LOCAL provider when we added support for
>  PAM_PRELIM_CHECK.
>   
ACK

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/18/2009 03:30 PM, Simo Sorce wrote:
>  On Fri, 18 Dec 2009 15:18:48 -0500
>  Stephen Gallagher <sgallagh(a)redhat.com&gt; wrote:
>  
> > We forgot the LOCAL provider when we added support for
> > PAM_PRELIM_CHECK.
> >
>  
>  ACK
>  
>  Simo.
>   
Pushed to master and 1-0-0.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAksr7EcACgkQeiVVYja6o6N0TACfWWPrkCi273p1jto9jRYKT2Dv
> mDEAn1uKi+mLEitquwxYFQRkkT7hOh3b
> =Oanr
> -----END PGP SIGNATURE-----

[David O'Brien]

Stephen Gallagher wrote:
>  -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>  
>  On 12/18/2009 03:30 PM, Simo Sorce wrote:
> > On Fri, 18 Dec 2009 15:18:48 -0500
> > Stephen Gallagher <sgallagh(a)redhat.com&gt; wrote:
> >
> >> We forgot the LOCAL provider when we added support for
> >> PAM_PRELIM_CHECK.
> >>
> > ACK
> >
> > Simo.
> >
>  
>  Pushed to master and 1-0-0.
>   
What's the doc impact or how do I use/test this?

-- 

David O'Brien
Red Hat Asia Pacific
[phone]


He who asks is a fool for five minutes, but he who does not ask remains 
a fool forever."
  ~ Chinese proverb

[Sumit Bose]

On Mon, Dec 21, 2009 at 01:32:27PM +1000, David O'Brien wrote:
>  Stephen Gallagher wrote:
>  > -----BEGIN PGP SIGNED MESSAGE-----
>  > Hash: SHA1
>  > 
>  > On 12/18/2009 03:30 PM, Simo Sorce wrote:
>  >> On Fri, 18 Dec 2009 15:18:48 -0500
>  >> Stephen Gallagher <sgallagh(a)redhat.com&gt; wrote:
>  >>
>  >>> We forgot the LOCAL provider when we added support for
>  >>> PAM_PRELIM_CHECK.
>  >>>
>  >> ACK
>  >>
>  >> Simo.
>  >>
>  > 
>  > Pushed to master and 1-0-0.
>  > 
>  What's the doc impact or how do I use/test this? 
There is no impact on the docs. The change only affect how a password
change request is processed internally. You can test it by trying to
change a password of a local user. If it works everything is fine, id it
fails either this patch is not applied or something else is broken.

I have changed the way change password request are handled because of
#326. In the patch for #326 I have changed the proxy, ldap and kerberos
provider but forgot LOCAL.

The visible change of #326 is the immediate response of the passwd
command if the user provives a wrong 'old' password. Without the patch
the user was asked for the old and the new password and only after
entering both he got a response if the old password was wrong.

bye,
Sumit


>  
>  -- 
>  
>  David O'Brien
>  Red Hat Asia Pacific
>  [phone]
>  
>  
>  He who asks is a fool for five minutes, but he who does not ask remains 
>  a fool forever."
>    ~ Chinese proverb
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel