So I didn't need to review this?
Here are some edits, if you would like to merge them (again, I was unable
to apply the match, so I did the edits inline of Pavel's patch).
On Thu, Jul 7, 2016 at 1:23 PM, Jakub Hrozek <jhrozek(a)redhat.com> wrote:
On Thu, Jul 07, 2016 at 07:18:55PM +0200, Michal Židek wrote:
> On 07/07/2016 07:12 PM, Michal Židek wrote:
> > On 07/07/2016 06:45 PM, Michal Židek wrote:
> > > The man page looks good to me with exception
> > > for one detail (see inline)
> > >
> > > On 07/04/2016 12:45 PM, Pavel Březina wrote:
> > > > + <refsect1 id='options'>
> > > > + <title>COMMON OPTIONS</title>
> > > > + <para>
> > > > + Those options are available with all commands.
> > > > + </para>
> > > > + <variablelist remap='IP'>
> > > > + <varlistentry>
> > > > + <term>
> > > > + <option>--debug</option>
> > > > + <replaceable>LEVEL</replaceable>
> > > > + </term>
> > > > + <xi:include
> > > >
xmlns:xi="http://www.w3.org/2001/XInclude"
> > > > href="include/debug_levels.xml" />
> > >
> > > This include contains some irrelevant information for sssctl
> > > that could be confusing for users. But I do not think we
> > > should block the patch, I will create a ticket to track this
> > > as a man page bug.
> > >
> > > > + </varlistentry>
> > > > + </variablelist>
> > > > + </refsect1>
> > > > +
> > > > + <xi:include
xmlns:xi="http://www.w3.org/2001/XInclude"
> > > > href="include/seealso.xml" />
> > > > +
> > >
> > > The attached patch is the same as Pavel's, with some
> > > whitespaces removed (git complaint about them).
> > >
> > > Otherwise LGTM ( == ACK, because we do not have much
> > > time and I think it is better than nothing).
> > >
> > > Michal
> >
> > The mailman is very slow today for some mails.
> >
> > Sending again with the hope it will arrive sooner.
> >
> > Michal
>
> Third time...
Because mailman has issues today, Michal sent me the patch in a direct
mail and I pushed it:
dc6dd1ef6a70a0a07017d362e13c7680e83c4fc8
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org