Glib fails if the NULL-terminator is included when a length is specified.
I recently pushed "Allow using Glib for UTF8 support" after doing excessive negative testing. However, I forgot to do positive testing and therefore failed to discover that Glib treats a NULL-terminator as an error in validation.
This patch changes our consumers to drop the NULL-terminator before passing it to validation. This works properly on both Glib and libunistring.
On Mon, 2011-12-05 at 13:44 -0500, Stephen Gallagher wrote:
Glib fails if the NULL-terminator is included when a length is specified.
I recently pushed "Allow using Glib for UTF8 support" after doing excessive negative testing. However, I forgot to do positive testing and therefore failed to discover that Glib treats a NULL-terminator as an error in validation.
This patch changes our consumers to drop the NULL-terminator before passing it to validation. This works properly on both Glib and libunistring.
Pushed to master, sssd-1-6 and sssd-1-5 under the one-liner rule. (It's the same one-liner repeated in four places).
On Mon, 2011-12-05 at 14:25 -0500, Stephen Gallagher wrote:
On Mon, 2011-12-05 at 13:44 -0500, Stephen Gallagher wrote:
Glib fails if the NULL-terminator is included when a length is specified.
I recently pushed "Allow using Glib for UTF8 support" after doing excessive negative testing. However, I forgot to do positive testing and therefore failed to discover that Glib treats a NULL-terminator as an error in validation.
This patch changes our consumers to drop the NULL-terminator before passing it to validation. This works properly on both Glib and libunistring.
Pushed to master, sssd-1-6 and sssd-1-5 under the one-liner rule. (It's the same one-liner repeated in four places).
Missed the netgroups case. Pushed to master, sssd-1-6 and sssd-1-5 under the one-liner rule.
sssd-devel@lists.fedorahosted.org
-
Stephen Gallagher