[sssd PR#211][opened] IFP: Fix of limit = 0 (unlimited result)

[celestian]

URL: https://github.com/SSSD/sssd/pull/211
Author: celestian
 Title: #211: IFP: Fix of limit = 0 (unlimited result)
Action: opened

PR body:
"""
If we set limit to 0 it means that result is unlimited. Internally we
restrict number of result by allocation of result array.
In unlimited case there was a bug and zero array was allocated.
This fix allocates neccessary array when we know real result size.

Resolves:
https://pagure.io/SSSD/sssd/issue/3306

How to test (this reproducer needs #208 "IFP: Filter with * in Users.ListByName method" applied)
```
systemctl daemon-reload
sudo su -c "truncate -s0 /var/log/sssd/*.log"
sudo su -c "rm -f /var/lib/sss/db/*" 
sudo su -c "rm -f /var/lib/sss/mc/*"
sudo systemctl restart sssd.service

sudo su -c "truncate -s0 /var/log/sssd/*.log"

dbus-send --system --print-reply  --dest=org.freedesktop.sssd.infopipe \
    /org/freedesktop/sssd/infopipe/Users \
    org.freedesktop.sssd.infopipe.Users.ListByName \
    string:"*" uint32:"0"

dbus-send --system --print-reply  --dest=org.freedesktop.sssd.infopipe \
    /org/freedesktop/sssd/infopipe/Groups \
    org.freedesktop.sssd.infopipe.Groups.ListByName \
    string:"*" uint32:"100"

dbus-send --system --print-reply  --dest=org.freedesktop.sssd.infopipe \
    /org/freedesktop/sssd/infopipe/Users \
    org.freedesktop.sssd.infopipe.Users.ListByDomainAndName \
    string:"domain.cygnus" string:"*" uint32:"100"
```
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/211/head:pr211
git checkout pr211

[sssd PR#211][comment] IFP: Fix of limit = 0 (unlimited result)

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/211
Title: #211: IFP: Fix of limit = 0 (unlimited result)

lslebodn commented:
"""
I didn't check the code. But would it be possible to hadle it
inside function `ifp_list_ctx_remaining_capacity` ?

Becasue newly added dbus call can have the same problem.
And IMHO it's better to solve problem on one place.
I hope it's possible.

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/211#issuecomment-289691209

[sssd PR#211][synchronized] IFP: Fix of limit = 0 (unlimited result)

[celestian]

URL: https://github.com/SSSD/sssd/pull/211
Author: celestian
 Title: #211: IFP: Fix of limit = 0 (unlimited result)
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/211/head:pr211
git checkout pr211

[sssd PR#211][comment] IFP: Fix of limit = 0 (unlimited result)

[celestian]

URL: https://github.com/SSSD/sssd/pull/211
Title: #211: IFP: Fix of limit = 0 (unlimited result)

celestian commented:
"""
@lslebodn thanks, that's good point. I synced new version of the patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/211#issuecomment-289727876

[sssd PR#211][comment] IFP: Fix of limit = 0 (unlimited result)

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/211
Title: #211: IFP: Fix of limit = 0 (unlimited result)

lslebodn commented:
"""
retest this please
"""

See the full comment at https://github.com/SSSD/sssd/pull/211#issuecomment-290705474

[sssd PR#211][synchronized] IFP: Fix of limit = 0 (unlimited result)

[fidencio]

URL: https://github.com/SSSD/sssd/pull/211
Author: celestian
 Title: #211: IFP: Fix of limit = 0 (unlimited result)
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/211/head:pr211
git checkout pr211

[sssd PR#211][comment] IFP: Fix of limit = 0 (unlimited result)

[fidencio]

URL: https://github.com/SSSD/sssd/pull/211
Title: #211: IFP: Fix of limit = 0 (unlimited result)

fidencio commented:
"""
I've updated @celestian's patchset and added one patch on top of his.

His patch looks okay to go, but I'll need a review on mine.
"""

See the full comment at https://github.com/SSSD/sssd/pull/211#issuecomment-300141692

[sssd PR#211][comment] IFP: Fix of limit = 0 (unlimited result)

[fidencio]

URL: https://github.com/SSSD/sssd/pull/211
Title: #211: IFP: Fix of limit = 0 (unlimited result)

fidencio commented:
"""
And there's one extra patch from me that's rebased on top of this series that ended up being pushed together (and, IMO, it's okay as it has to rebased on top of these patches anyways).
"""

See the full comment at https://github.com/SSSD/sssd/pull/211#issuecomment-300142263

[sssd PR#211][synchronized] IFP: Fix of limit = 0 (unlimited result)

[fidencio]

URL: https://github.com/SSSD/sssd/pull/211
Author: celestian
 Title: #211: IFP: Fix of limit = 0 (unlimited result)
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/211/head:pr211
git checkout pr211

[sssd PR#211][comment] IFP: Fix of limit = 0 (unlimited result)

[fidencio]

URL: https://github.com/SSSD/sssd/pull/211
Title: #211: IFP: Fix of limit = 0 (unlimited result)

fidencio commented:
"""
retest this, please
"""

See the full comment at https://github.com/SSSD/sssd/pull/211#issuecomment-318154121

[sssd PR#211][synchronized] IFP: Fix of limit = 0 (unlimited result)

[fidencio]

URL: https://github.com/SSSD/sssd/pull/211
Author: celestian
 Title: #211: IFP: Fix of limit = 0 (unlimited result)
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/211/head:pr211
git checkout pr211

[sssd PR#211][comment] IFP: Fix of limit = 0 (unlimited result)

[fidencio]

URL: https://github.com/SSSD/sssd/pull/211
Title: #211: IFP: Fix of limit = 0 (unlimited result)

fidencio commented:
"""
@pbrezina, could you take a look on this patchset, please?

I've reviewed @celestian's patches, but ended up adding two patches on top of his, so I can't ACK my own patches :-)
"""

See the full comment at https://github.com/SSSD/sssd/pull/211#issuecomment-319084394

[sssd PR#211][comment] IFP: Fix of limit = 0 (unlimited result)

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/211
Title: #211: IFP: Fix of limit = 0 (unlimited result)

pbrezina commented:
"""
Ack. I opened: https://github.com/SSSD/sssd/pull/356 for a typo in man pages.
"""

See the full comment at https://github.com/SSSD/sssd/pull/211#issuecomment-324879332

[sssd PR#211][+Accepted] IFP: Fix of limit = 0 (unlimited result)

[fidencio]

URL: https://github.com/SSSD/sssd/pull/211
Title: #211: IFP: Fix of limit = 0 (unlimited result)

Label: +Accepted

[sssd PR#211][comment] IFP: Fix of limit = 0 (unlimited result)

[fidencio]

URL: https://github.com/SSSD/sssd/pull/211
Title: #211: IFP: Fix of limit = 0 (unlimited result)

fidencio commented:
"""
Added "Accepted" label per @pbrezina's review.
"""

See the full comment at https://github.com/SSSD/sssd/pull/211#issuecomment-324901151

[sssd PR#211][comment] IFP: Fix of limit = 0 (unlimited result)

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/211
Title: #211: IFP: Fix of limit = 0 (unlimited result)

lslebodn commented:
"""
master:
* b0b9222f7dd62b19ec702afe295ec71624888e87
* 5d855b5d546eb995023d80d61433bbe91888dbdf
* 3c31ce392ad9da4ac7c3d8190db89efcdbbc8b85
* 5fe1e8ba91a1e2e95aadf94ecc5148bec804aa5a

"""

See the full comment at https://github.com/SSSD/sssd/pull/211#issuecomment-325010705

[sssd PR#211][closed] IFP: Fix of limit = 0 (unlimited result)

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/211
Author: celestian
 Title: #211: IFP: Fix of limit = 0 (unlimited result)
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/211/head:pr211
git checkout pr211