[sssd PR#365][opened] PYTHON: Define constants as bytes instead of strings

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/365
Author: fidencio
 Title: #365: PYTHON: Define constants as bytes instead of strings
Action: opened

PR body:
"""
When using python3 getsidbyname() and getnamebysid() expect the key as
bytes instead of strings, and currently those are defined as strings.
So, in order to avoid people working around this by doing
`pysss_nss_idmap.SID_KEY.encode('utf-8')` let's make their life easier
and properly have those constants defined as bytes.

Resolves: https://pagure.io/SSSD/sssd/issue/3491

Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com&gt;
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/365/head:pr365
git checkout pr365

[sssd PR#365][comment] PYTHON: Define constants as bytes instead of strings

[mzidek-rh]

  URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings

mzidek-rh commented:
"""
I do like the change, but isn't this going to break existing python3 code, that uses
pysss_nss_idmap.SID_KEY.encode('utf-8')?
"""

See the full comment at https://github.com/SSSD/sssd/pull/365#issuecomment-326273028

[sssd PR#365][comment] PYTHON: Define constants as bytes instead of strings

[flo-renaud]

  URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings

flo-renaud commented:
"""
Hi @fidencio 
thank you for your patch. I tested it with python3 and freeipa ipa-winsync-migrate and it
works well.
"""

See the full comment at https://github.com/SSSD/sssd/pull/365#issuecomment-326283685

[sssd PR#365][comment] PYTHON: Define constants as bytes instead of strings

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings

fidencio commented:
"""
@mzidek-rh: Yes, it's going to change the behaviour for code that uses
pysss_nss_idmap.SID_KEY.encode('utf-8').

Btw, there was some really internal discussion about this before having this PR opened
where IPA developers discussed about "(...) We can have a hack with SID_KEY =
pysss_nss_idmap.SID_KEY.encode('utf-8') or ask to fix in the python bindings.
(...)" and the answer was "(...) we'd better have them [sssd] fix this I
think (...)".

So, in general, it will change the behaviour but seems to be the right approach.

By the way, as I won't be able to touch this code for a week or so (PTO), whoever
review it, please, feel free to push to my branch (as I don't think we should delay
those patch too much).
"""

See the full comment at https://github.com/SSSD/sssd/pull/365#issuecomment-326287436

[sssd PR#365][comment] PYTHON: Define constants as bytes instead of strings

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings

jhrozek commented:
"""
Does this code also changes anything with respect to Python2? Because not many
distributions default to python3 yet, and while some are moving there, like Fedora, I
think we should do the change now rather than wait.
Also, AFAIK the only (current?) consumer is IPA.

So +1 from me about merging now.
"""

See the full comment at https://github.com/SSSD/sssd/pull/365#issuecomment-326303699

[sssd PR#365][comment] PYTHON: Define constants as bytes instead of strings

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings

jhrozek commented:
"""
So I'm adding Accepted label and unless someone complains, I'll push the patch
later.
"""

See the full comment at https://github.com/SSSD/sssd/pull/365#issuecomment-326303932

[sssd PR#365][+Accepted] PYTHON: Define constants as bytes instead of strings

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings

Label: +Accepted

[sssd PR#365][comment] PYTHON: Define constants as bytes instead of strings

[mzidek-rh]

  URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings

mzidek-rh commented:
"""
Fine by me. I agree that we should make the python 3 API as clean as possible before more
people start using it.
"""

See the full comment at https://github.com/SSSD/sssd/pull/365#issuecomment-326308056

[sssd PR#365][comment] PYTHON: Define constants as bytes instead of strings

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings

fidencio commented:
"""
@jhrozek, there are no changes with respect to python 2.
"""

See the full comment at https://github.com/SSSD/sssd/pull/365#issuecomment-326311975

[sssd PR#365][comment] PYTHON: Define constants as bytes instead of strings

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings

jhrozek commented:
"""
* master: 9375eae59550437c85ada9212be430a4242b25a4
"""

See the full comment at https://github.com/SSSD/sssd/pull/365#issuecomment-326398985

[sssd PR#365][closed] PYTHON: Define constants as bytes instead of strings

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/365
Author: fidencio
 Title: #365: PYTHON: Define constants as bytes instead of strings
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/365/head:pr365
git checkout pr365

[sssd PR#365][+Pushed] PYTHON: Define constants as bytes instead of strings

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings

Label: +Pushed