[PATCHES] BUILD: Speed up build of some tests

[Lukas Slebodnik]

ehlo,

Attached patches reduce count of compiled ".c" files
from 935 -> 815 (almost 9%). This reduction is achieved
in deduplication of compiling "*.c" files in tests.

BTW the tests were compiled 4 times in our CI script.
 * make tests
 * mock build
 * make distcheck
 * code coverage

The result saving will not be 9% of time due to parallel build
but it still worth. (and Makefile.am is simpler)

LS

[Jakub Hrozek]

On Wed, Sep 02, 2015 at 06:50:43AM +0200, Lukas Slebodnik wrote:
> ehlo,
>
> Attached patches reduce count of compiled ".c" files
> from 935 -> 815 (almost 9%). This reduction is achieved
> in deduplication of compiling "*.c" files in tests.
>
> BTW the tests were compiled 4 times in our CI script.
> make tests
> mock build
> make distcheck
> code coverage
>
> The result saving will not be 9% of time due to parallel build
> but it still worth. (and Makefile.am is simpler)
>
> LS

Thanks for the patches, they seem to work fine for me as well, ACK. My
CI run is:
    http://sssd-ci.duckdns.org/logs/job/25/31/summary.html

btw what do you think about splitting tests from Makefile.am into
tests/Makefile.am? I think we talked about this before and there was
some opposition but I no longer remember what it was..

[Jakub Hrozek]

On Sat, Sep 05, 2015 at 10:52:19PM +0200, Jakub Hrozek wrote:
> On Wed, Sep 02, 2015 at 06:50:43AM +0200, Lukas Slebodnik wrote:
> > ehlo,
> >
> > Attached patches reduce count of compiled ".c" files
> > from 935 -> 815 (almost 9%). This reduction is achieved
> > in deduplication of compiling "*.c" files in tests.
> >
> > BTW the tests were compiled 4 times in our CI script.
> > make tests
> > mock build
> > make distcheck
> > code coverage
> >
> > The result saving will not be 9% of time due to parallel build
> > but it still worth. (and Makefile.am is simpler)
> >
> > LS
>
> Thanks for the patches, they seem to work fine for me as well, ACK. My
> CI run is:
>     http://sssd-ci.duckdns.org/logs/job/25/31/summary.html

Pushed to master:
    * af3a627a3ff5402aad02edc6d48576b3c69458e5
    * 802909e59daa52c734dbe7f8fa13b0ee23e3e576
    * 1116fbbf0e50827841a6bafd80c027c3d3548c1f

[Lukas Slebodnik]

On (05/09/15 23:03), Jakub Hrozek wrote:
> On Sat, Sep 05, 2015 at 10:52:19PM +0200, Jakub Hrozek wrote:
> > On Wed, Sep 02, 2015 at 06:50:43AM +0200, Lukas Slebodnik wrote:
> > > ehlo,
> > >
> > > Attached patches reduce count of compiled ".c" files
> > > from 935 -> 815 (almost 9%). This reduction is achieved
> > > in deduplication of compiling "*.c" files in tests.
> > >
> > > BTW the tests were compiled 4 times in our CI script.
> > > make tests
> > > mock build
> > > make distcheck
> > > code coverage
> > >
> > > The result saving will not be 9% of time due to parallel build
> > > but it still worth. (and Makefile.am is simpler)
> > >
> > > LS
> >
> > Thanks for the patches, they seem to work fine for me as well, ACK. My
> > CI run is:
> >     http://sssd-ci.duckdns.org/logs/job/25/31/summary.html
>
> Pushed to master:
> 802909e59daa52c734dbe7f8fa13b0ee23e3e576
> 1116fbbf0e50827841a6bafd80c027c3d3548c1f

Pushed also 1-12 branch to avoid linking bug
http://sssd-ci.duckdns.org/logs/job/37/36/debian_testing/ci-build-debug/ci-m...

sssd-1-12:
* 0ae21618d6afece1fd5b756155e586a5ae2b2942
* 53219cc4b9d05514dab972d0917cb57693b3064b

LS