URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: opened
PR body: """
"""
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain
Label: +Tests
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain
sidecontrol commented: """ I forgot, please go through the pep8 failures and correct them. """
See the full comment at https://github.com/SSSD/sssd/pull/5689#issuecomment-881268314
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: edited
Changed field: title Original value: """ Tests: Add tests ported from bash for AD Parameters Domain """
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
jakub-vavra-cz commented: """ `PHASE START: test Phase timeout: 14400s
UPSTREAM TESTS STEP START: src/tests/multihost/ad/test_adparameters_ported.py ============================= test session starts ============================== platform linux -- Python 3.9.5, pytest-3.10.1, py-1.10.0, pluggy-0.13.1 -- /usr/bin/python3 cachedir: .pytest_cache metadata: {'Python': '3.9.5', 'Platform': 'Linux-5.13.7-100.fc33.x86_64-x86_64-with-glibc2.33', 'Packages': {'pytest': '3.10.1', 'py': '1.10.0', 'pluggy': '0.13.1'}, 'Plugins': {'html': '1.22.1', 'multihost': '3.4', 'metadata': '1.11.0'}} rootdir: /root/tews/sssd/src/tests/multihost/ad, inifile: pytest.ini plugins: html-1.22.1, multihost-3.4, metadata-1.11.0 collecting ... collected 42 items
src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0001_ad_parameters_domain PASSED [ 2%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0002_ad_parameters_junk_domain PASSED [ 4%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0003_ad_parameters_junk_domain_invalid_keytab PASSED [ 7%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0004_ad_parameters_valid_domain_shorthost PASSED [ 9%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0005_ad_parameters_blank_domain PASSED [ 11%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0006_ad_parameters_homedir_override_nss PASSED [ 14%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0007_ad_parameters_homedir_override_domain PASSED [ 16%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0008_ad_parameters_homedir_override_both PASSED [ 19%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0009_ad_parameters_ldap_sasl_full SKIPPED [ 21%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0010_ad_parameters_ldap_sasl_short SKIPPED [ 23%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0011_ad_parameters_server_resolvable PASSED [ 26%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0012_ad_parameters_server_unresolvable PASSED [ 28%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0013_ad_parameters_server_srv_record PASSED [ 30%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0014_ad_parameters_server_blank PASSED [ 33%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0015_ad_parameters_ad_hostname_machine PASSED [ 35%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0016_ad_parameters_ad_hostname_valid PASSED [ 38%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0017_ad_parameters_krb5_keytab_nonexistent PASSED [ 40%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0018_ad_parameters_krb5_keytab_elsewhere PASSED [ 42%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0019_ad_parameters_ldap_id_mapping_false PASSED [ 45%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0020_ad_parameters_ssh_change_password PASSED [ 47%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0021_ad_parameters_ssh_change_password_logon PASSED [ 50%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0022_ad_parameters_account_disabled PASSED [ 52%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0023_ad_parameters_account_expired PASSED [ 54%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0024_ad_parameters_getgrgid_nested PASSED [ 57%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0025_ad_parameters_empty_group PASSED [ 59%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0026_ad_parameters_dns_failover PASSED [ 61%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0027_ad_parameters_group_membership_empty PASSED [ 64%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0028_ad_parameters_nested_in_nonposix_group PASSED [ 66%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0029_ad_parameters_tokengroups_with_ldap PASSED [ 69%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0030_ad_parameters_tokengroups_searchbase PASSED [ 71%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0031_ad_parameters_custom_re PASSED [ 73%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0032_ad_parameters_group_name_attribute PASSED [ 76%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0033_ad_parameters_group_cleanup_sanitize PASSED [ 78%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0034_ad_parameters_group_work_intermittently PASSED [ 80%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0035_ad_parameters_delete_cache PASSED [ 83%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0036_ad_parameters_renewal_leaks_descriptors PASSED [ 85%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0037_ad_parameters_extra_attrs_mail PASSED [ 88%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0038_ad_parameters_authentication_failure_invalid_keytab PASSED [ 90%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0039_ad_parameters_auth_krb5 PASSED [ 92%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0040_ad_parameters_newline_ssh_key PASSED [ 95%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0041_ad_parameters_sss_ssh_knownhostsproxy PASSED [ 97%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0042_ad_parameters_nonroot_user_sssd PASSED [100%]
-------------- generated xml file: /root/tews/bash-old/junit.xml --------------- --------- generated html file: file:///root/tews/bash-old/report.html ---------- =================== 40 passed, 2 skipped in 5903.69 seconds ==================== RETURN CODE: 0 UPSTREAM TESTS STEP END: src/tests/multihost/ad/test_adparameters_ported.py PHASE END: test ` """
See the full comment at https://github.com/SSSD/sssd/pull/5689#issuecomment-915179060
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
jakub-vavra-cz commented: """ I was able to execute and pass all of the tests apart from the sasl ones:
`PHASE START: test Phase timeout: 14400s
UPSTREAM TESTS STEP START: src/tests/multihost/ad/test_adparameters_ported.py ============================= test session starts ============================== platform linux -- Python 3.9.5, pytest-3.10.1, py-1.10.0, pluggy-0.13.1 -- /usr/bin/python3 cachedir: .pytest_cache metadata: {'Python': '3.9.5', 'Platform': 'Linux-5.13.7-100.fc33.x86_64-x86_64-with-glibc2.33', 'Packages': {'pytest': '3.10.1', 'py': '1.10.0', 'pluggy': '0.13.1'}, 'Plugins': {'html': '1.22.1', 'multihost': '3.4', 'metadata': '1.11.0'}} rootdir: /root/tews/sssd/src/tests/multihost/ad, inifile: pytest.ini plugins: html-1.22.1, multihost-3.4, metadata-1.11.0 collecting ... collected 42 items
src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0001_ad_parameters_domain PASSED [ 2%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0002_ad_parameters_junk_domain PASSED [ 4%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0003_ad_parameters_junk_domain_invalid_keytab PASSED [ 7%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0004_ad_parameters_valid_domain_shorthost PASSED [ 9%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0005_ad_parameters_blank_domain PASSED [ 11%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0006_ad_parameters_homedir_override_nss PASSED [ 14%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0007_ad_parameters_homedir_override_domain PASSED [ 16%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0008_ad_parameters_homedir_override_both PASSED [ 19%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0009_ad_parameters_ldap_sasl_full SKIPPED [ 21%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0010_ad_parameters_ldap_sasl_short SKIPPED [ 23%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0011_ad_parameters_server_resolvable PASSED [ 26%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0012_ad_parameters_server_unresolvable PASSED [ 28%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0013_ad_parameters_server_srv_record PASSED [ 30%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0014_ad_parameters_server_blank PASSED [ 33%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0015_ad_parameters_ad_hostname_machine PASSED [ 35%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0016_ad_parameters_ad_hostname_valid PASSED [ 38%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0017_ad_parameters_krb5_keytab_nonexistent PASSED [ 40%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0018_ad_parameters_krb5_keytab_elsewhere PASSED [ 42%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0019_ad_parameters_ldap_id_mapping_false PASSED [ 45%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0020_ad_parameters_ssh_change_password PASSED [ 47%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0021_ad_parameters_ssh_change_password_logon PASSED [ 50%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0022_ad_parameters_account_disabled PASSED [ 52%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0023_ad_parameters_account_expired PASSED [ 54%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0024_ad_parameters_getgrgid_nested PASSED [ 57%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0025_ad_parameters_empty_group PASSED [ 59%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0026_ad_parameters_dns_failover PASSED [ 61%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0027_ad_parameters_group_membership_empty PASSED [ 64%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0028_ad_parameters_nested_in_nonposix_group PASSED [ 66%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0029_ad_parameters_tokengroups_with_ldap PASSED [ 69%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0030_ad_parameters_tokengroups_searchbase PASSED [ 71%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0031_ad_parameters_custom_re PASSED [ 73%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0032_ad_parameters_group_name_attribute PASSED [ 76%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0033_ad_parameters_group_cleanup_sanitize PASSED [ 78%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0034_ad_parameters_group_work_intermittently PASSED [ 80%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0035_ad_parameters_delete_cache PASSED [ 83%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0036_ad_parameters_renewal_leaks_descriptors PASSED [ 85%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0037_ad_parameters_extra_attrs_mail PASSED [ 88%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0038_ad_parameters_authentication_failure_invalid_keytab PASSED [ 90%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0039_ad_parameters_auth_krb5 PASSED [ 92%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0040_ad_parameters_newline_ssh_key PASSED [ 95%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0041_ad_parameters_sss_ssh_knownhostsproxy PASSED [ 97%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0042_ad_parameters_nonroot_user_sssd PASSED [100%]
-------------- generated xml file: /root/tews/bash-old/junit.xml --------------- --------- generated html file: file:///root/tews/bash-old/report.html ---------- =================== 40 passed, 2 skipped in 5903.69 seconds ==================== RETURN CODE: 0 UPSTREAM TESTS STEP END: src/tests/multihost/ad/test_adparameters_ported.py PHASE END: test ` """
See the full comment at https://github.com/SSSD/sssd/pull/5689#issuecomment-915179060
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
jakub-vavra-cz commented: """ Here is the execution in jenkins: https://ci-jenkins-csb-idmops.apps.ocp-c1.prod.psi.redhat.com/job/trigger-te... """
See the full comment at https://github.com/SSSD/sssd/pull/5689#issuecomment-916902432
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
jakub-vavra-cz commented: """ I was able to execute and pass all of the tests apart from the sasl ones:
`PHASE START: test Phase timeout: 14400s
UPSTREAM TESTS STEP START: src/tests/multihost/ad/test_adparameters_ported.py ============================= test session starts ============================== platform linux -- Python 3.9.5, pytest-3.10.1, py-1.10.0, pluggy-0.13.1 -- /usr/bin/python3 cachedir: .pytest_cache metadata: {'Python': '3.9.5', 'Platform': 'Linux-5.13.7-100.fc33.x86_64-x86_64-with-glibc2.33', 'Packages': {'pytest': '3.10.1', 'py': '1.10.0', 'pluggy': '0.13.1'}, 'Plugins': {'html': '1.22.1', 'multihost': '3.4', 'metadata': '1.11.0'}} rootdir: /root/tews/sssd/src/tests/multihost/ad, inifile: pytest.ini plugins: html-1.22.1, multihost-3.4, metadata-1.11.0 collecting ... collected 42 items
src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0001_ad_parameters_domain PASSED [ 2%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0002_ad_parameters_junk_domain PASSED [ 4%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0003_ad_parameters_junk_domain_invalid_keytab PASSED [ 7%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0004_ad_parameters_valid_domain_shorthost PASSED [ 9%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0005_ad_parameters_blank_domain PASSED [ 11%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0006_ad_parameters_homedir_override_nss PASSED [ 14%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0007_ad_parameters_homedir_override_domain PASSED [ 16%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0008_ad_parameters_homedir_override_both PASSED [ 19%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0009_ad_parameters_ldap_sasl_full SKIPPED [ 21%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0010_ad_parameters_ldap_sasl_short SKIPPED [ 23%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0011_ad_parameters_server_resolvable PASSED [ 26%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0012_ad_parameters_server_unresolvable PASSED [ 28%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0013_ad_parameters_server_srv_record PASSED [ 30%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0014_ad_parameters_server_blank PASSED [ 33%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0015_ad_parameters_ad_hostname_machine PASSED [ 35%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0016_ad_parameters_ad_hostname_valid PASSED [ 38%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0017_ad_parameters_krb5_keytab_nonexistent PASSED [ 40%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0018_ad_parameters_krb5_keytab_elsewhere PASSED [ 42%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0019_ad_parameters_ldap_id_mapping_false PASSED [ 45%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0020_ad_parameters_ssh_change_password PASSED [ 47%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0021_ad_parameters_ssh_change_password_logon PASSED [ 50%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0022_ad_parameters_account_disabled PASSED [ 52%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0023_ad_parameters_account_expired PASSED [ 54%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0024_ad_parameters_getgrgid_nested PASSED [ 57%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0025_ad_parameters_empty_group PASSED [ 59%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0026_ad_parameters_dns_failover PASSED [ 61%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0027_ad_parameters_group_membership_empty PASSED [ 64%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0028_ad_parameters_nested_in_nonposix_group PASSED [ 66%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0029_ad_parameters_tokengroups_with_ldap PASSED [ 69%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0030_ad_parameters_tokengroups_searchbase PASSED [ 71%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0031_ad_parameters_custom_re PASSED [ 73%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0032_ad_parameters_group_name_attribute PASSED [ 76%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0033_ad_parameters_group_cleanup_sanitize PASSED [ 78%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0034_ad_parameters_group_work_intermittently PASSED [ 80%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0035_ad_parameters_delete_cache PASSED [ 83%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0036_ad_parameters_renewal_leaks_descriptors PASSED [ 85%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0037_ad_parameters_extra_attrs_mail PASSED [ 88%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0038_ad_parameters_authentication_failure_invalid_keytab PASSED [ 90%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0039_ad_parameters_auth_krb5 PASSED [ 92%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0040_ad_parameters_newline_ssh_key PASSED [ 95%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0041_ad_parameters_sss_ssh_knownhostsproxy PASSED [ 97%] src/tests/multihost/ad/test_adparameters_ported.py::TestADParamsPorted::test_0042_ad_parameters_nonroot_user_sssd PASSED [100%]
-------------- generated xml file: /root/tews/bash-old/junit.xml --------------- --------- generated html file: file:///root/tews/bash-old/report.html ---------- =================== 40 passed, 2 skipped in 5903.69 seconds ==================== RETURN CODE: 0 UPSTREAM TESTS STEP END: src/tests/multihost/ad/test_adparameters_ported.py PHASE END: test ` """
See the full comment at https://github.com/SSSD/sssd/pull/5689#issuecomment-915179060
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
sidecontrol commented: """ Really nice, clean code, thank you Jakub, LG2M! """
See the full comment at https://github.com/SSSD/sssd/pull/5689#issuecomment-921412041
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5689
* `master` * a5716cd74a7c8bdf7a64a4862cccc5380884b483 - Tests: Add AD Parameters tests ported from bash.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5689#issuecomment-922830227
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5689 Author: jakub-vavra-cz Title: #5689: Tests: Add tests ported from bash for AD Parameters Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5689/head:pr5689 git checkout pr5689
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters
Label: -Ready to push
sssd-devel@lists.fedorahosted.org
-
jakub-vavra-cz -
pbrezina
-
sidecontrol