[sssd PR#51][opened] TOOL: Fixing of sign-compare warning

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/51
Author: celestian
 Title: #51: TOOL: Fixing of sign-compare warning
Action: opened

PR body:
"""
Warning was on src/tools/tools_util.c:116.
(We have fixed this issue at master.)
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/51/head:pr51
git checkout pr51

[sssd PR#51][comment] TOOL: Fixing of sign-compare warning

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/51
Title: #51: TOOL: Fixing of sign-compare warning

lslebodn commented:
"""
I can see that's already fixed in master
https://git.fedorahosted.org/cgit/sssd.git/commit/?id=d3f14ed93ef61268d0a...

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/51#issuecomment-254226115

[sssd PR#51][+Rejected] TOOL: Fixing of sign-compare warning

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/51
Title: #51: TOOL: Fixing of sign-compare warning

Label: +Rejected

[sssd PR#51][closed] TOOL: Fixing of sign-compare warning

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/51
Author: celestian
 Title: #51: TOOL: Fixing of sign-compare warning
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/51/head:pr51
git checkout pr51

[sssd PR#51][comment] TOOL: Fixing of sign-compare warning

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/51
Title: #51: TOOL: Fixing of sign-compare warning

lslebodn commented:
"""
I hit enter too fast. We backport patches in different way.
```
git checkout sssd-1-13
git cherry-pick -x d3f14ed93ef61268d0a68898ed9c44b4f773081c

```
The important the argument `-x`. It adds a very useful comment to the commit message.
`(cherry picked from commit d3f14ed93ef61268d0a68898ed9c44b4f773081c)`
Otherwise it's very difficult to track whether a patch was backported to stable branch
or no.
"""

See the full comment at https://github.com/SSSD/sssd/pull/51#issuecomment-254230426

[sssd PR#51][comment] TOOL: Fixing of sign-compare warning

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/51
Title: #51: TOOL: Fixing of sign-compare warning

celestian commented:
"""
Hi @lslebodn,
I know about another three issues which we should backport to 1.13.
I could prepare patches with ```git cherry-pick -x <commit number>``` and create
PRs.
Is this the right way?
"""

See the full comment at https://github.com/SSSD/sssd/pull/51#issuecomment-254239001

[sssd PR#51][comment] TOOL: Fixing of sign-compare warning

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/51
Title: #51: TOOL: Fixing of sign-compare warning

celestian commented:
"""
Hi @lslebodn,
I know about another three issues which we should backport to 1.13.
I could prepare patches with ```git cherry-pick -x <commit number>``` and create
PRs.
Is this the right way?
"""

See the full comment at https://github.com/SSSD/sssd/pull/51#issuecomment-254239001

[sssd PR#51][comment] TOOL: Fixing of sign-compare warning

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/51
Title: #51: TOOL: Fixing of sign-compare warning

lslebodn commented:
"""
On (17/10/16 08:20), celestian wrote:
> Hi @lslebodn,
> I know about another three issues which we should backport to 1.13.
> I could prepare patches with ```git cherry-pick -x <commit number>``` and create
> PRs.
> Is this the right way?
>  
It is correct for patches which has PR for master.
For older patches it's better to bump the thread with
patches for master.

e.g.
https://lists.fedorahosted.org/archives/list/[e-mail]...

"""

See the full comment at https://github.com/SSSD/sssd/pull/51#issuecomment-254242698