[PATCH] UTIL: Include netinet/in.h for ip adress macros

[Lukas Slebodnik]

ehlo,

The manual page in.h (man in.h) says:
   The <netinet/in.h> header shall define the in6_addr structure that con‐
   tains at least the following member:
                    uint8_t s6_addr[16]
   The  <netinet/in.h>  header shall define the following macros that test
   for special IPv6 addresses. Each macro is of type int and takes a  sin‐
   gle argument of type const struct in6_addr *:
        IN6_IS_ADDR_LINKLOCAL: Unicast link-local address.
        IN6_IS_ADDR_LOOPBACK: Loopback address.
        IN6_IS_ADDR_MULTICAST: Multicast address.

The header file netinet/in.h> was not included directly in src/util/util.c
and it caused few problems.

LS

[Lukas Slebodnik]

On (24/05/14 19:11), Lukas Slebodnik wrote:
> ehlo,
>
> The manual page in.h (man in.h) says:
>    The <netinet/in.h> header shall define the in6_addr structure that con‐
>    tains at least the following member:
>                     uint8_t s6_addr[16]
>    The  <netinet/in.h>  header shall define the following macros that test
>    for special IPv6 addresses. Each macro is of type int and takes a  sin‐
>    gle argument of type const struct in6_addr *:
>         IN6_IS_ADDR_LINKLOCAL: Unicast link-local address.
>         IN6_IS_ADDR_LOOPBACK: Loopback address.
>         IN6_IS_ADDR_MULTICAST: Multicast address.
>
> The header file netinet/in.h> was not included directly in src/util/util.c
> and it caused few problems.
>
> LS 
attached patch with small change.

LS

[Jakub Hrozek]

On Sat, May 24, 2014 at 07:38:52PM +0200, Lukas Slebodnik wrote:
>  On (24/05/14 19:11), Lukas Slebodnik wrote:
>  >ehlo,
>  >
>  >The manual page in.h (man in.h) says:
>  >   The <netinet/in.h> header shall define the in6_addr structure that con‐
>  >   tains at least the following member:
>  >                    uint8_t s6_addr[16]
>  >   The  <netinet/in.h>  header shall define the following macros that test
>  >   for special IPv6 addresses. Each macro is of type int and takes a  sin‐
>  >   gle argument of type const struct in6_addr *:
>  >        IN6_IS_ADDR_LINKLOCAL: Unicast link-local address.
>  >        IN6_IS_ADDR_LOOPBACK: Loopback address.
>  >        IN6_IS_ADDR_MULTICAST: Multicast address.
>  >
>  >The header file netinet/in.h> was not included directly in src/util/util.c
>  >and it caused few problems.
>  >
>  >LS
>  
>  attached patch with small change.
>  
>  LS 
Similar to other patches in the mini-thread, I only tested by building
on F-20 and RHEL-6. The build went fine, no new errors or warnings.

ACK

[Jakub Hrozek]

On Mon, May 26, 2014 at 04:52:46PM +0200, Jakub Hrozek wrote:
>  On Sat, May 24, 2014 at 07:38:52PM +0200, Lukas Slebodnik wrote:
>  > On (24/05/14 19:11), Lukas Slebodnik wrote:
>  > >ehlo,
>  > >
>  > >The manual page in.h (man in.h) says:
>  > >   The <netinet/in.h> header shall define the in6_addr structure that
> con‐
>  > >   tains at least the following member:
>  > >                    uint8_t s6_addr[16]
>  > >   The  <netinet/in.h>  header shall define the following macros that
> test
>  > >   for special IPv6 addresses. Each macro is of type int and takes a  sin‐
>  > >   gle argument of type const struct in6_addr *:
>  > >        IN6_IS_ADDR_LINKLOCAL: Unicast link-local address.
>  > >        IN6_IS_ADDR_LOOPBACK: Loopback address.
>  > >        IN6_IS_ADDR_MULTICAST: Multicast address.
>  > >
>  > >The header file netinet/in.h> was not included directly in src/util/util.c
>  > >and it caused few problems.
>  > >
>  > >LS
>  > 
>  > attached patch with small change.
>  > 
>  > LS
>  
>  Similar to other patches in the mini-thread, I only tested by building
>  on F-20 and RHEL-6. The build went fine, no new errors or warnings.
>  
>  ACK 
Pushed to master: aad67c44ecebb6a674a280fa5f00cbc0a68e9052