[sssd PR#5253][opened] libdirsrv should be modified to be compatible with new DS

List overview All Threads
Download

newer

older

[sssd PR#5241][comment] GPO:...

[sssd PR#5301][opened] use...

aborah-sudo

23 Jul 2020 23 Jul '20

8:20 a.m.

URL: https://github.com/SSSD/sssd/pull/5253 Author: aborah-sudo Title: #5253: libdirsrv should be modified to be compatible with new DS Action: opened

PR body: """

"""

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5253/head:pr5253 git checkout pr5253

Attachments:

sssd-pr-5253.patch (text/x-diff — 6.9 KB)

Show replies by date

aborah-sudo

23 Jul 23 Jul

8:42 a.m.

New subject: [sssd PR#5253][synchronized] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Author: aborah-sudo Title: #5253: libdirsrv should be modified to be compatible with new DS Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5253/head:pr5253 git checkout pr5253

aborah-sudo

9:01 a.m.

New subject: [sssd PR#5253][synchronized] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Author: aborah-sudo Title: #5253: libdirsrv should be modified to be compatible with new DS Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5253/head:pr5253 git checkout pr5253

alexey-tikhonov

11:39 a.m.

New subject: [sssd PR#5253][comment] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

alexey-tikhonov commented: """ Hi,

Thank you for the patch.

I think it would be great to provide some details in the commit message. Something like: what version is "new", a brief description of required changes and if those changes are backward compatible. """

See the full comment at https://github.com/SSSD/sssd/pull/5253#issuecomment-662913198

aborah-sudo

1:37 p.m.

New subject: [sssd PR#5253][synchronized] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Author: aborah-sudo Title: #5253: libdirsrv should be modified to be compatible with new DS Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5253/head:pr5253 git checkout pr5253

aborah-sudo

1:38 p.m.

New subject: [sssd PR#5253][comment] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

aborah-sudo commented: """

...

Hi,

Thank you for the patch.

I think it would be great to provide some details in the commit message. Something like: what version is "new", a brief description of required changes and if those changes are backward compatible.

Directory Server 1.4.x

As DS is going to get rid of setup-ds.pl file completely. We need to change the same on our side too. """

See the full comment at https://github.com/SSSD/sssd/pull/5253#issuecomment-662958075

aborah-sudo

28 Jul 28 Jul

8:47 a.m.

New subject: [sssd PR#5253][synchronized] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Author: aborah-sudo Title: #5253: libdirsrv should be modified to be compatible with new DS Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5253/head:pr5253 git checkout pr5253

aborah-sudo

9:04 a.m.

New subject: [sssd PR#5253][synchronized] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Author: aborah-sudo Title: #5253: libdirsrv should be modified to be compatible with new DS Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5253/head:pr5253 git checkout pr5253

sumit-bose

21 Aug 21 Aug

8:23 a.m.

New subject: [sssd PR#5253][comment] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

sumit-bose commented: """ Hi,

as we agreed I'm fine with ACKing the patch. I just had a minor comment while reading it.

bye, Sumit """

See the full comment at https://github.com/SSSD/sssd/pull/5253#issuecomment-678065147

pbrezina

27 Aug 27 Aug

12:36 p.m.

New subject: [sssd PR#5253][+Changes requested] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

Label: +Changes requested

mrniranjan

31 Aug 31 Aug

2:05 p.m.

New subject: [sssd PR#5253][comment] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

mrniranjan commented: """ @aborah-sudo Can you modify the line in the patch with below changes:

` set_trust_cmd = 'certutil -M -d %s -n %s -t ' \ '"CT,C,T" -f %s' % (self.dsinst_path, canick, pwfile) ` """

See the full comment at https://github.com/SSSD/sssd/pull/5253#issuecomment-683737608

mrniranjan

2:06 p.m.

New subject: [sssd PR#5253][comment] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

mrniranjan commented: """ @aborah-sudo Can you modify the line in the patch with below changes:

` set_trust_cmd = 'certutil -M -d %s -n %s -t ' \ '"CT,C,T" -f %s' % (self.dsinst_path, canick, pwfile) ` """

See the full comment at https://github.com/SSSD/sssd/pull/5253#issuecomment-683737608

aborah-sudo

2:14 p.m.

New subject: [sssd PR#5253][synchronized] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Author: aborah-sudo Title: #5253: libdirsrv should be modified to be compatible with new DS Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5253/head:pr5253 git checkout pr5253

aborah-sudo

2:15 p.m.

New subject: [sssd PR#5253][synchronized] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Author: aborah-sudo Title: #5253: libdirsrv should be modified to be compatible with new DS Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5253/head:pr5253 git checkout pr5253

aborah-sudo

2:15 p.m.

New subject: [sssd PR#5253][comment] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

aborah-sudo commented: """ changes are done """

See the full comment at https://github.com/SSSD/sssd/pull/5253#issuecomment-683742126

mrniranjan

3:39 p.m.

New subject: [sssd PR#5253][comment] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

mrniranjan commented: """ @aborah-sudo can you move the -t to the next line

ie. ` set_trust_cmd = 'certutil -M -d %s -n %s ' \ ' -t "CT,C,T" -f %s' % (self.dsinst_path, canick, pwfile) ` """

See the full comment at https://github.com/SSSD/sssd/pull/5253#issuecomment-683784987

aborah-sudo

3:47 p.m.

New subject: [sssd PR#5253][synchronized] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Author: aborah-sudo Title: #5253: libdirsrv should be modified to be compatible with new DS Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5253/head:pr5253 git checkout pr5253

aborah-sudo

3:48 p.m.

New subject: [sssd PR#5253][comment] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

aborah-sudo commented: """ @mrniranjan done """

See the full comment at https://github.com/SSSD/sssd/pull/5253#issuecomment-683790043

sumit-bose

1 Sep 1 Sep

8:49 a.m.

New subject: [sssd PR#5253][comment] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

sumit-bose commented: """ Hi,

thanks for the changes. ACK.

bye, Sumit """

See the full comment at https://github.com/SSSD/sssd/pull/5253#issuecomment-684478552

sumit-bose

8:50 a.m.

New subject: [sssd PR#5253][+Accepted] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

Label: +Accepted

sumit-bose

8:50 a.m.

New subject: [sssd PR#5253][-Changes requested] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

Label: -Changes requested

pbrezina

11:32 a.m.

New subject: [sssd PR#5253][+Ready to push] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

Label: +Ready to push

pbrezina

11:36 a.m.

New subject: [sssd PR#5253][comment] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5253

* `master` * 2f4140fa663b74c5390e2c4f3647db0505ff5f85 - libdirsrv should be modified to be compatible with new DS

"""

See the full comment at https://github.com/SSSD/sssd/pull/5253#issuecomment-684667276

pbrezina

11:36 a.m.

New subject: [sssd PR#5253][+Pushed] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

Label: +Pushed

pbrezina

11:36 a.m.

New subject: [sssd PR#5253][-Accepted] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

Label: -Accepted

pbrezina

11:36 a.m.

New subject: [sssd PR#5253][-Ready to push] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Title: #5253: libdirsrv should be modified to be compatible with new DS

Label: -Ready to push

pbrezina

11:36 a.m.

New subject: [sssd PR#5253][closed] libdirsrv should be modified to be compatible with new DS

URL: https://github.com/SSSD/sssd/pull/5253 Author: aborah-sudo Title: #5253: libdirsrv should be modified to be compatible with new DS Action: closed

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5253/head:pr5253 git checkout pr5253

1468

Age (days ago)

1508

Last active (days ago)

sssd-devel@lists.fedorahosted.org

26 comments

5 participants

tags (0)

participants (5)

aborah-sudo
alexey-tikhonov
mrniranjan
pbrezina
sumit-bose