On (03/09/14 00:30), Noam Meltzer wrote:
---
src/man/Makefile.am | 4 +-
src/man/include/seealso.xml | 4 ++
src/man/sss_rpcidmapd.5.xml | 132 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 139 insertions(+), 1 deletion(-)
create mode 100644 src/man/sss_rpcidmapd.5.xml
diff --git a/src/man/Makefile.am b/src/man/Makefile.am
index 546e0ad..a92ac0d 100644
--- a/src/man/Makefile.am
+++ b/src/man/Makefile.am
@@ -45,7 +45,9 @@ man_MANS = \
sssd.8 sssd.conf.5 sssd-ldap.5 \
sssd-krb5.5 sssd-simple.5 \
sssd_krb5_locator_plugin.8 sss_groupshow.8 \
- pam_sss.8 sss_obfuscate.8 sss_cache.8 sss_debuglevel.8 sss_seed.8
+ pam_sss.8 sss_obfuscate.8 sss_cache.8 sss_debuglevel.8 sss_seed.8 \
+ sss_rpcidmapd.5 \
+ $(NULL)
I let review of patch for native speaker.
I would prefer different way of splitting patches. There main reason is
bissecting. The problem of this patch is that rpms cannot be built.
RPM build errors:
error: Installed (but unpackaged) file(s) found:
/usr/share/man/man5/sss_rpcidmapd.5.gz
Installed (but unpackaged) file(s) found:
/usr/share/man/man5/sss_rpcidmapd.5.gz
Child return code was: 1
In my opinon, you can squash all two patches into one.
LS