[PATCHES] Initgroups support for RFC2307bis nested groups (master)

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Patch 0001: Modify sysdb_[add|remove]_group_member to accept users and
groups

Previously, it assumed that all members were users. This changes
the interface so that either a user or a group can be specified.

Also, it eliminates the need for a memory context to be passed,
since the internal memory should be self-contained.


Patch 0002: Add proper nested initgroup support for RFC2307bis servers


Both of these patches are forward-ported from SSSD 1.2.4 (adjusting for
sysdb changes).

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAky7nR0ACgkQeiVVYja6o6Pc0ACfQ8HrRu1jglyMiQb1sNITy9dS
> g5UAnRbQI8d2cF+ev0KjaJQ73qN/BQLE
> =T69a
> -----END PGP SIGNATURE-----

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/18/2010 03:04 AM, Stephen Gallagher wrote:
>  Patch 0001: Modify sysdb_[add|remove]_group_member to accept users
> and
>  groups
>  
>  Previously, it assumed that all members were users. This changes
>  the interface so that either a user or a group can be specified.
>  
>  Also, it eliminates the need for a memory context to be passed,
>  since the internal memory should be self-contained.
>  
>   
Ack

>  Patch 0002: Add proper nested initgroup support for RFC2307bis
> servers
>  
>  
>  Both of these patches are forward-ported from SSSD 1.2.4 (adjusting for
>  sysdb changes).
>   
Two minor issues - in rfc2307bis_nested_groups_step(), the second
sysdb_attrs_get_string() for SYSDB_NAME is not needed.

In rfc2307bis_nested_groups_process(), there should be a return
following the tevent_req_error() after calling
rfc2307bis_nested_groups_step(). The same code is also in
rfc2307bis_nested_groups_done().

Otherwise looks OK.

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAky8LGgACgkQHsardTLnvCVZnACfT+Nt4g+ieJuZSDcddWFeaj5g
> ESYAmgN1TpVc98TYmU02GXd4uPn91AX5
> =1kP0
> -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/18/2010 07:15 AM, Jakub Hrozek wrote:
>  On 10/18/2010 03:04 AM, Stephen Gallagher wrote:
> > Patch 0001: Modify sysdb_[add|remove]_group_member to accept users and
> > groups
>  
> > Previously, it assumed that all members were users. This changes
> > the interface so that either a user or a group can be specified.
>  
> > Also, it eliminates the need for a memory context to be passed,
> > since the internal memory should be self-contained.
>  
>  
>  
>  Ack
>  
> > Patch 0002: Add proper nested initgroup support for RFC2307bis servers
>  
>  
> > Both of these patches are forward-ported from SSSD 1.2.4 (adjusting for
> > sysdb changes).
>  
>  
>  Two minor issues - in rfc2307bis_nested_groups_step(), the second
>  sysdb_attrs_get_string() for SYSDB_NAME is not needed.
>   
Thanks, that was a cut-and-paste where I forgot the "cut" step :)

>  In rfc2307bis_nested_groups_process(), there should be a return
>  following the tevent_req_error() after calling
>  rfc2307bis_nested_groups_step(). The same code is also in
>  rfc2307bis_nested_groups_done().
>  
>  Otherwise looks OK.
>   
You are correct about rfc2307bis_nested_groups_done(). However, there's
no issue in rfc2307bis_nested_groups_step(). For economy of space, I
just included a single return statement outside the if/else blocks.

New patch attached.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAky8OHsACgkQeiVVYja6o6OECACdGEceacBsCzuRMFQb0v3lAy0X
> sPQAn1NxPOc1BrGAGs6eMQZ5qu0Dr5k2
> =7ZLX
> -----END PGP SIGNATURE-----

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/18/2010 02:07 PM, Stephen Gallagher wrote:
>  On 10/18/2010 07:15 AM, Jakub Hrozek wrote:
> > On 10/18/2010 03:04 AM, Stephen Gallagher wrote:
> >> Patch 0001: Modify sysdb_[add|remove]_group_member to accept users and
> >> groups
>  
> >> Previously, it assumed that all members were users. This changes
> >> the interface so that either a user or a group can be specified.
>  
> >> Also, it eliminates the need for a memory context to be passed,
> >> since the internal memory should be self-contained.
>  
>  
>  
> > Ack
>  
> >> Patch 0002: Add proper nested initgroup support for RFC2307bis servers
>  
>  
> >> Both of these patches are forward-ported from SSSD 1.2.4 (adjusting for
> >> sysdb changes).
>  
>  
> > Two minor issues - in rfc2307bis_nested_groups_step(), the second
> > sysdb_attrs_get_string() for SYSDB_NAME is not needed.
>  
>  
>  Thanks, that was a cut-and-paste where I forgot the "cut" step :)
>  
> > In rfc2307bis_nested_groups_process(), there should be a return
> > following the tevent_req_error() after calling
> > rfc2307bis_nested_groups_step(). The same code is also in
> > rfc2307bis_nested_groups_done().
>  
> > Otherwise looks OK.
>  
>  
>  You are correct about rfc2307bis_nested_groups_done(). However, there's
>  no issue in rfc2307bis_nested_groups_step(). For economy of space, I
>  just included a single return statement outside the if/else blocks.
>  
>  New patch attached.
>   
Ack to both
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAky8SXAACgkQHsardTLnvCXGHgCfSKS/AlOFEaC0oBY1UMKgLucw
> i8oAoLfSqcJVqO9vDqi660mNxDCYjELw
> =6r83
> -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/18/2010 09:19 AM, Jakub Hrozek wrote:
>  On 10/18/2010 02:07 PM, Stephen Gallagher wrote:
> > On 10/18/2010 07:15 AM, Jakub Hrozek wrote:
> >> On 10/18/2010 03:04 AM, Stephen Gallagher wrote:
> >>> Patch 0001: Modify sysdb_[add|remove]_group_member to accept users and
> >>> groups
>  
> >>> Previously, it assumed that all members were users. This changes
> >>> the interface so that either a user or a group can be specified.
>  
> >>> Also, it eliminates the need for a memory context to be passed,
> >>> since the internal memory should be self-contained.
>  
>  
>  
> >> Ack
>  
> >>> Patch 0002: Add proper nested initgroup support for RFC2307bis servers
>  
>  
> >>> Both of these patches are forward-ported from SSSD 1.2.4 (adjusting for
> >>> sysdb changes).
>  
>  
> >> Two minor issues - in rfc2307bis_nested_groups_step(), the second
> >> sysdb_attrs_get_string() for SYSDB_NAME is not needed.
>  
>  
> > Thanks, that was a cut-and-paste where I forgot the "cut" step :)
>  
> >> In rfc2307bis_nested_groups_process(), there should be a return
> >> following the tevent_req_error() after calling
> >> rfc2307bis_nested_groups_step(). The same code is also in
> >> rfc2307bis_nested_groups_done().
>  
> >> Otherwise looks OK.
>  
>  
> > You are correct about rfc2307bis_nested_groups_done(). However, there's
> > no issue in rfc2307bis_nested_groups_step(). For economy of space, I
> > just included a single return statement outside the if/else blocks.
>  
> > New patch attached.
>  
>  
>  Ack to both 

Pushed to master.


- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAky8gEIACgkQeiVVYja6o6MwpgCgrAGfdUfe2WLpu+gML52IGWIe
> tMMAn0m+7xQBDpsM7vOokIfHJ0Yu2ysa
> =IPD1
> -----END PGP SIGNATURE-----